Skip to main content

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index] [List Home]
Re: [wtp-pmc] ACTION REQUIRED: Two small webservices fixes for RC3 - please merge TODAY

Regarding the number of +1s needed, looks like it's just 1 approval we need, based on what was done for Oxygen.3 [1].

[1] https://wiki.eclipse.org/WTP_2018-02-08#3.9.3_Schedule

On Fri, Jun 1, 2018 at 9:03 AM, Nick Boldt <nboldt@xxxxxxxxxx> wrote:
Adding PMC to cc:.

For 256772 [1], we have uber-PMC Elson, other-PMC Neil, and Keith is still MIA, leaving you, Shane, in charge of Webservices to cast his vote. 

"Just a heads up. I am on vacation and will be back June 4th. If you need something committed to Web Services (eg. or change the JEE features), please contact Shane." - Keith, on May 10

For 5334747 [2], we have again Elson & Neil again approving conditional to lead approval, which is again you, Shane, to cast the deciding vote.


Therefore, both issues have 3 votes apiece.

Is that sufficient? Can you merge these fixes?

Note that if we wait until next week when Keith is back online and has found the bottom of his email backlog (3 weeks of email is a lot to get through), we may miss the RC3 deadline (Tuesday June 5 is Photon RC3 +2 day).

So this is urgent to be pushed TODAY, so that I can get it built and a smoke test page created.

Thanks,

Nick 

On Thu, May 31, 2018 at 5:25 PM, Shane Clarke <shane_clarke@xxxxxxxxxxx> wrote:
Hi Nick,

I was waiting for the PMC votes. Both Neil and Elson are looking for project lead approval on the bugzilla. I commented on it but i haven't seen any votes yet. How many do we need? I thought it was 3 for RC3.

I'll check back in the morning (GMT time) if i don't see anything soon and i'll merge if it's been approved.

Thanks,
Shane

From: Nick Boldt <nboldt@xxxxxxxxxx>
Sent: Thursday 31 May 2018 22:17
To: Shane Clarke; Mat Booth; Keith Chong
Subject: Re: Change 122761 in webservices/webtools.webservices[master]: Bug 534747 - Use import-package for deps that can be supplie...
 
Thanks for the +2, Shane. Can you also merge it?

Nick

On Thu, May 31, 2018 at 2:36 PM, Shane Clarke (Code Review) <gerrit@xxxxxxxxxxx> wrote:
Shane Clarke has posted comments on this change. ( https://git.eclipse.org/r/122761 )

Change subject: Bug 534747 - Use import-package for deps that can be supplied by the jre
......................................................................


Patch Set 2: Code-Review+2

+2, change looks good


--
To view, visit https://git.eclipse.org/r/122761
To unsubscribe, visit https://git.eclipse.org/r/settings

Gerrit-Project: webservices/webtools.webservices
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: If9306cee2fae7cda444c9eaacf0ea054f1ee061a
Gerrit-Change-Number: 122761
Gerrit-PatchSet: 2
Gerrit-Owner: Mat Booth <mat.booth@xxxxxxxxxx>
Gerrit-Reviewer: CI Bot
Gerrit-Reviewer: Mat Booth <mat.booth@xxxxxxxxxx>
Gerrit-Reviewer: Nick Boldt <nboldt@xxxxxxxxxx>
Gerrit-Reviewer: Shane Clarke <shane_clarke@xxxxxxxxxxx>
Gerrit-Comment-Date: Thu, 31 May 2018 18:36:55 +0000
Gerrit-HasComments: No



--

Nick Boldt

Principal Software Engineer, RHCSA

Productization Lead :: JBoss Tools & Dev Studio

IM: @nickboldt / @nboldt / http://nick.divbyzero.com



“The Only Thing That Is Constant Is Change” - Heraclitus



--

Nick Boldt

Principal Software Engineer, RHCSA

Productization Lead :: JBoss Tools & Dev Studio

IM: @nickboldt / @nboldt / http://nick.divbyzero.com



“The Only Thing That Is Constant Is Change” - Heraclitus



--

Nick Boldt

Principal Software Engineer, RHCSA

Productization Lead :: JBoss Tools & Dev Studio

IM: @nickboldt / @nboldt / http://nick.divbyzero.com



“The Only Thing That Is Constant Is Change” - Heraclitus

Back to the top