Re: [wtp-pmc] [wtp-dev] WTP releng.aggregator 3.10 Integration build bro

[Nick Boldt <nboldt@xxxxxxxxxx>]

I imagine it's because I've started running the builds with Tycho 1.0 instead of 0.22, so as to expose problems like these early in the Photon development cycle and fix them before it's too late. 

Now that JDK 9 is out, building with Maven 3.3 and Tycho 0.x is no longer a wise move; we should be using Maven 3.5 and Tycho 1.0, so that when a JDK9-compliant version of Tycho comes out (1.1.0-SNAPSHOT doesn't YET include a JDT that understands JDK 9), we'll be ready to move up to that. 

Thanks for looking into the compilation failure. If it would help accelerate things, you could nominate me to the various project(s) with similar problems, so I can push fixes w/o needing to wait for gerrit reviews. 

On Wed, Oct 18, 2017 at 12:04 PM, Carl Anderson <ccc@xxxxxxxxxx> wrote:

Nick,

There is no "JEM team" - WTP took over JEM from the VE team when it disbanded years ago. Over the years, I have maintained the JEM code, though.
This is a very interesting problem- as you can tell, the error appears in an (important) JavaDoc comment. Interestingly enough, the type that is referenced, org.eclipse.jdt.core.IType, is in a package that is exported and the plugin has Eclipse-ExtensibleAPI: true set. So when the error message states:
[ERROR] Access restriction: The type 'IType' is not API (restriction on classpath entry '/home/hudson/genie.webtools/.hudson/jobs/WTP-R3_10_Integration/workspace/.maven/repo/p2/osgi/bundle/org.eclipse.jdt.core/3.14.0.v20171013-1440/org.eclipse.jdt.core-3.14.0.v20171013-1440.jar

I get confused- why is our build suddenly stating that a JavaDoc comment (that hasn't changed in years) that references an API is an error because the API is not an API? This seems like a build change to a builder with an issue, instead of anything that the code needs to change for. Did something change in the WTP-R3_10_Integration build? (A different Maven/Tycho/something else?) This is not our only reference to org.eclipse.jdt.core.IType - if we fix this comment, will we suddenly get errors in the other WTP references?

FWIW,

- Carl Anderson
WTP Java EE Tools committer

Nick Boldt ---10/18/2017 11:26:13 AM---Not sure which is the best list to send this to, so I'm spamming 3: PMC, releng, and dev. Please for

From: Nick Boldt <nboldt@xxxxxxxxxx>
To: Webtools releng discussion list <wtp-releng@xxxxxxxxxxx>, "General discussion of project-wide or architectural issues." <wtp-dev@xxxxxxxxxxx>, WTP PMC communications <wtp-pmc@xxxxxxxxxxx>
Date: 10/18/2017 11:26 AM
Subject: [wtp-dev] WTP releng.aggregator 3.10 Integration build broken for a whole week! Who can help fix?
Sent by: wtp-dev-bounces@xxxxxxxxxxx

---

Not sure which is the best list to send this to, so I'm spamming 3: PMC, releng, and dev. Please forgive me, I'm new. :)

I've been sending mail all week about this to various people but as yet haven't seen a reply or a fix.

TL;DR, this job [1] is broken. On Oct 13 build #74, it was due to a compilation error in JEM, which I reported to Chuck, Carl, and Elson as I wasn't sure who owns JEM and figured they could have a look or forward the problem to the correct owner(s). This was still failing as of Oct 17 build #78.

[1] https://hudson.eclipse.org/webtools/job/WTP-R3_10_Integration/

Now there's a new problem, which is probably due to Rob's getting a plugin moved out of Common and into Javaee. 

I'll have a look at the latter issue, but could someone with push rights to the webtools.javaee repo look at the JEM compilation failure? 

[ERROR] Failed to execute goal org.eclipse.tycho:tycho-compiler-plugin:1.0.0:compile (default-compile) on project org.eclipse.jem: Compilation failure: Compilation failure:
[ERROR] /jobs/genie.webtools/WTP-R3_10_Integration/workspace/webtools.javaee/plugins/org.eclipse.jem/mofjava/org/eclipse/jem/java/JavaClass.java:[407]
[ERROR] * will be an {@link org.eclipse.jdt.core.IType}, or running outside of Eclipse it will be a {@link java.lang.Class}.
[ERROR] ^^^^^^^^^^^^^^^^^^^^^^^^^^


Thanks everyone!

Aside: both the Common and Servertools builds are now building and running over 230 tests each. See links / updates here [2].

[2] https://wiki.eclipse.org/WTP_2017-10-12#WTP_3.10.0:_Repo_Re-org_And_Releng_Redux

--
Nick Boldt
Senior Software Engineer, RHCSA
Productization Lead :: JBoss Tools & Dev Studio
IM: @nickboldt / @nboldt / http://nick.divbyzero.com

TRIED. TESTED. TRUSTED.

@ @redhatnews      Red Hat_______________________________________________
wtp-dev mailing list
wtp-dev@xxxxxxxxxxx
To change your delivery options, retrieve your password, or unsubscribe from this list, visit
https://urldefense.proofpoint.com/v2/url?u=https-3A__dev.eclipse.org_mailman_listinfo_wtp-2Ddev&d=DwICAg&c=jf_iaSHvJObTbx-siA1ZOg&r=6JCYBixIS0G6Rj43h5xZSA&m=CwH7L9U7-BCDqosMy37HVDBuLPPL7_wkLD895ed7HGo&s=lVuUmjTwx_Ly9Jkj3yldfBspsgQFx-yHzkoE_U_sthQ&e=

_______________________________________________
wtp-dev mailing list
wtp-dev@xxxxxxxxxxx
To change your delivery options, retrieve your password, or unsubscribe from this list, visit
https://dev.eclipse.org/mailman/listinfo/wtp-dev

--

Nick Boldt

Senior Software Engineer, RHCSA

Productization Lead :: JBoss Tools & Dev Studio

IM: @nickboldt / @nboldt / http://nick.divbyzero.com

TRIED. TESTED. TRUSTED.

@ @redhatnews      Red Hat