Skip to main content

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index] [List Home]
[wtp-pmc] Fwd: pmc_approved requested: [Bug 517659] com.google.javascript and com.google.guava plugins not added to org.eclipse.wst.jsdt.feature

Dear PMC Members,

please, take a look at the following issue [1] as it needs your attention for 3.9.0 RC3. The fix for the issue is provided through Gerrit [2]:

[1] https://bugs.eclipse.org/bugs/show_bug.cgi?id=517659 - [Bug 517659] com.google._javascript_ and com.google.guava plugins not added to org.eclipse.wst.jsdt.feature

[2] https://git.eclipse.org/r/98469 - Fix for Bug 517659

Thanks in advance,

Victor Rubezhny,

JSDT




-------- Forwarded Message --------
Subject: pmc_approved requested: [Bug 517659] com.google._javascript_ and com.google.guava plugins not added to org.eclipse.wst.jsdt.feature
Date: Thu, 01 Jun 2017 21:07:52 +0000
From: bugzilla-daemon@xxxxxxxxxxx
To: vrubezhny@xxxxxxxxxx


Victor Rubezhny <vrubezhny@xxxxxxxxxx> has asked Victor Rubezhny
<vrubezhny@xxxxxxxxxx> for pmc_approved:
Bug 517659: com.google._javascript_ and com.google.guava plugins not added to
org.eclipse.wst.jsdt.feature
https://bugs.eclipse.org/bugs/show_bug.cgi?id=517659



--- Comment #2 from Victor Rubezhny <vrubezhny@xxxxxxxxxx> ---
Requesting PMC approval in order to to add the required plug-ins to
org.eclipse.wst.jsdt.feature. 
See: https://git.eclipse.org/r/98469

* Explain why you believe this is a stop-ship defect. Or, if it is a "hotbug"
(requested by an adopter) please document it as such.

This is necessary to reference the required dependencies to satisfy p2
requirements during the installation.

* Is there a work-around? If so, why do you believe the work-around is
insufficient?

No work-around.

* How has the fix been tested? Is there a test case attached to the bugzilla
record? Has a JUnit Test been added?

The contribution is tested manually (by running the maven build and executing
the existing JUnit tests). 

* Give a brief technical overview. Who has reviewed this fix?

The contribution adds the references to com.google.guava and
com.google._javascript_ to org.eclipse.wst.jsdt.feature, thus 
making it to satisfy p2 requirements during the installation process.

* What is the risk associated with this fix?

Very low or no risk at all as the plug-ins are really required and used by JSDT
Core.

Back to the top