Skip to main content

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index] [List Home]
Re: [wtp-incubator-dev] Smoke Test Time

The reason they are unpacked is so that they expose their jar files. These jar files are added to the classpath of the launched XSLT transformation, they are not on the Eclipse classpath.
 
Having said that, I am using the FileLocator API which means that the jars will be pulled out and unpacked if the plugin is a packed one, which would add some small overhead while launching so I'd rather have those particular plugins unpacked. But if it really offends you, you can pack them.


 
----- Original Message ----
From: David M Williams <david_williams@xxxxxxxxxx>
To: WTP Incubator Dev list <wtp-incubator-dev@xxxxxxxxxxx>
Sent: Thursday, 17 January, 2008 1:20:48 PM
Subject: Re: [wtp-incubator-dev] Smoke Test Time


> What is the penalty for breaking the build at Eclipse? Virtual cake,
> remote beer? ;-)


Well, if it is a really bad (i.e. dumb) one at a critical time, we might ask for a picture of
you wearing a red clown nose  :) ... but, you did good for your first time ...
especially that you were able to diagnose and fix it quickly (and, don't worry,
I was watching closely ready to jump in if needed, but I know there's a lot
learned by having to struggle through it, so didn't want to jump in too quick).

>  - I don't fully understand why some of the plugins are packed as jars
> and others are folders, but that's probably just me.


The mechanics of this is in the feature.xml file. That little "unpack=false"
attribute at the end will cause it to be (left as) a jar.

Conceptually, they should all be packed, unless there's reasons it can not be,
and if there are reasons it can not be (e.g. someone is using old-fashioned IO
based on the plugin location) then that should be tracked as a bug, and fixed
eventually.





From: Jesper Steen Møller <jesper@xxxxxxxxxxxxx>
To: WTP Incubator Dev list <wtp-incubator-dev@xxxxxxxxxxx>
Date: 01/16/2008 11:39 AM
Subject: Re: [wtp-incubator-dev] Smoke Test Time





David Carver wrote:
> Doug and Jesper:
>
> Time to do some smoke tests of the builds that David Williams has been
> running for us.  I'm going to try and take some time to pull down the
> builds today and see how they work.   If you run into a major bug in
> what you have already committed, please provide a patch back into the
> head stream.
>
> If everything looks good, we should be good to go for a M1 build for
> the community to kick the tires on and start providing feedback.
>
I think I added the core plugin to the map and the feature, but I'm not
totally convinced. I'll check with the build pages later.

What is the penalty for breaking the build at Eclipse? Virtual cake,
remote beer? ;-)

-Jesper


_______________________________________________
wtp-incubator-dev mailing list
wtp-incubator-dev@xxxxxxxxxxx
https://dev.eclipse.org/mailman/listinfo/wtp-incubator-dev



Back to the top