Skip to main content

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index] [List Home]
Re: [wtp-dev] Nashorn Debugging

On 10 Apr 2015, at 20:36, Harald Wellmann wrote:

I've now pushed a snapshot of my Nashorn experiments to GitHub:

 https://github.com/hwellmann/webtools.jsdt

Any chance you can push this to Gerrit instead of "only" in a github branch ?

You cans how at https://wiki.eclipse.org/JSDT/Development#Pushing_a_new_patch_for_review

Then making comments/review gets much simpler - even if just a proof-of-concept.

Please see the README in bundles/org.eclipse.wst.jsdt.debug.nashorn for a
brief description of the design ideas and a simple test case.

for the lazy ones:
https://github.com/hwellmann/webtools.jsdt/blob/master/bundles/org.eclipse.wst.jsdt.debug.nashorn/README.md

The code is
nothing but a spike and absolutely unpolished - I'd be very happy to get some feedback from the project team before proceeding any further on what
might be the wrong track.

I'm not really sure if the current approach of a JavaScript debug target
acting as a facade for an underlying Java debug target is the best
approach, but I can't think of an obvious alternative at the moment.

Somehow it feels like JDT is hiding a lot of JDI APIs I'd like to use, but
this may be just my lack of expertise with JDT. At any rate, all the
x-friends package exports both in JDT and jsdt.debug.core seem to be a bit
of a code smell.

I think it would make sense to jdt-ui-dev where the JDT guys might be able to
provide insights on why and how.


Next thing I'll try upgrading to Mars M6 and take a look at the JDT patch
for the line location issue (bugzilla 462932).

Great!

/max
http://about.me/maxandersen


Back to the top