Skip to main content
[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index] [List Home]
Re: [wtp-dev] The Bower IDE contribution
Mickael,

I didn't merged the code in master, since we still have few issues that blocks us from doing it in Mars (I don't think we can get them fixed in time for Mars, so it looks like we're missing Mars stream with this contribution).

IMHO, It's better to write your suggestions here (in mailing list) first, because I'm going to push another patch set into Gerrit ( https://git.eclipse.org/r/#/c/41693/ ), so if you have some code comments to do then your comments could be 'forgotten'. But still free to add comments to the change.

IMHO, contributing it into master will not make any harm (visually it will add few actions to context menus) for WTP and JSDT, all the 'issues' are only on how Bower IDE works. But it looks unfinished at the moment and still have few important issues to be fixed before that possible merge to master. M6 is going to be declared today or in few days, so it looks like it's too late to merge. I'm sure we can finish it for the Mars+1 stream.

But I'd still like to hear/read on your suggestions.

Regards,
Victor Rubezhny


On 03/23/2015 01:38 PM, Mickael Istria wrote:
On 03/17/2015 07:37 AM, Mickael Istria wrote:
On 03/16/2015 02:44 PM, Victor V. Rubezhny wrote:
I think it's a good proposal to merge the current Bower IDE into master, but I don't get how I can make it go into the build and not include it into JSDT/JSDT_SDK features at the same time: If I'm not including the plug-ins, will they be built still and added into the update site?
The idea is to add it to the pom.xml so it gets built and to add it as a separate entry in the category.xml (under an Experimental or Incubation category of JSDT). Then, if necessary/useful, we may also tweak the global WTP category.xml to include it there as well.
@Victor: so did you merge the code in master? Is it still worth commenting on the Gerrit review ( https://git.eclipse.org/r/#/c/41693/ )? I could put comments there to explain how to integrate it into the JSDT build without altering what's delievered to WTP and Simrel in a 1st time.
--
Mickael Istria
Eclipse developer at JBoss, by Red Hat
My blog - My Tweets


_______________________________________________
wtp-dev mailing list
wtp-dev@xxxxxxxxxxx
To change your delivery options, retrieve your password, or unsubscribe from this list, visit
https://dev.eclipse.org/mailman/listinfo/wtp-dev

Back to the top