Victor,
I believe that the Bower contribution should be pushed to master when
you believe that it is ready. We can treat it like we have treated
the JPA
Diagram Editor. If there are sufficient-enough issues for us to not
have
this enabled by default, we can also add in a default to disable it,
and
allow a way for users that want/need it enabled to enable it.
The main question I would have about the slowness would be for
non-JSDT users that use WTP. Will there be an overall performance
impact
from these plugins? Or is it limited to just people that use JSDT?
From
what I read below, it seems to be limited to those that use JSDT. If
this
truly degrades the performance of WTP for all users, it should be
disabled
by default. But we can discuss that and other options as necessary.
Please let me know if you have any questions/comments/concerns.
FWIW,
- Carl Anderson
WTP Build guy
From: "Victor V. Rubezhny" <vrubezhny@xxxxxxxxxx>
To: Max Rydahl Andersen <max.andersen@xxxxxxxxxx>, Mickael Istria
<mistria@xxxxxxxxxx>
Cc: gorkem.ercan@xxxxxxxxx, "external-exadel-list@xxxxxxxxxx"
<external-exadel-list@xxxxxxxxxx>, "General discussion of
project-wide or architectural issues." <wtp-dev@xxxxxxxxxxx>
Date: 03/16/2015 09:44 AM
Subject: Re: [wtp-dev] The Bower IDE contribution
Sent by: wtp-dev-bounces@xxxxxxxxxxx
Max, Mickael,
actually we have all the required dependencies since the following
issues were fixed:
- https://bugs.eclipse.org/bugs/show_bug.cgi?id=457483 - Move JGit and
EGit to offset+1 on release train
- https://bugs.eclipse.org/bugs/show_bug.cgi?id=458521 - Add JGit/EGit
as a dependency of WTP
I think it's a good proposal to merge the current Bower IDE into
master,
but I don't get how I can make it go into the build and not include it
into JSDT/JSDT_SDK features at the same time: If I'm not including the
plug-ins, will they be built still and added into the update site?
Today I'm testing the fixes provided by Stephane for the following
issues:
- https://bugs.eclipse.org/bugs/show_bug.cgi?id=462110 - [bower]
Install/Update commands don't follow the NPM Node SemVer rules
- https://bugs.eclipse.org/bugs/show_bug.cgi?id=462108 - [bower]
Install/Update command block the UI, no way to cancel the operation
- https://bugs.eclipse.org/bugs/show_bug.cgi?id=462117 - [bower]
JsonSyntaxException exception occurs in Bower IDE while installing
angular dependency
If we've got these issues fixed, we could get something like a preview
for the contribution:
- anyway, we cannot get 'slow install' in time (it hardly depends on
upstream JGit issue:
https://bugs.eclipse.org/bugs/show_bug.cgi?id=301628
-BasePackFetchConnection: implement shallow support)
- Probably we can get at least a partial fix for 'registry' property
in
.bowerrc file (https://bugs.eclipse.org/bugs/show_bug.cgi?id=462112 -
[bower] The Bower Preference page is to be replaced by the support of
.bowerrc file)
- Also, for sure we can hide the Bower->Update command (which
currently
does just "Clean + Install", so in conjunction with the slowness of
"Install" operation has no sense to keep it at the moment.
As such, we're getting a "preview"-version with two big issue
(Install/update slowness + JSDT (including 3rd party products that
depends on it, like Tern.java and VJET) starts to get slow when too
many
files are "installed' according to bower.json configuration. See:
- https://bugs.eclipse.org/bugs/show_bug.cgi?id=462115 - [bower] Do we
need to exclude dependencies installed by bower from the JSDT Include
Path?
- https://issues.jboss.org/browse/JBIDE-19448 - (JBIDE-19448)
Performance problems with angular-phonecat project
Any thoughts?
Thanks in advance,
Victor
On 03/16/2015 04:11 PM, Max Rydahl Andersen wrote:
On 16 Mar 2015, at 9:30, Mickael Istria wrote:
Hi Victor, hi all,
I don't get how this contribution can have blockers that make it
worth being on a separate branch. Indeed, the bower integration may
not yet be ready to be delivered as part of a release, but since
it's
a set of separate plugins, I would find it more convenient to put
this directly on master, to build it together with the regular JSDT,
but to mark it as Incubating, with version 0.0.1. However, it should
remain out of the main feature (the one we ship to Release Train)
until to becomes more stable.
I believe this approach would bring more additional testers and
contributors on this Bower integration and would help a lot to reach
high quality faster.
WDYT?
Since this depends on things not available in the master branch (like
jgit) it was put in separate branch to at least have it *somewhere*.
/max
http://about.me/maxandersen
_______________________________________________
wtp-dev mailing list
wtp-dev@xxxxxxxxxxx
To change your delivery options, retrieve your password, or
unsubscribe
from this list, visit
https://dev.eclipse.org/mailman/listinfo/wtp-dev
_______________________________________________
wtp-dev mailing list
wtp-dev@xxxxxxxxxxx
To change your delivery options, retrieve your password, or
unsubscribe from this list, visit
https://dev.eclipse.org/mailman/listinfo/wtp-dev
