Skip to main content

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index] [List Home]
Re: [wtp-dev] Choose XML Formatter based on Priority

One of the issues that I need to fix, is that the Android XML editor and formater, look for any *.xml file, and they assume they should take it over.   I need to make that Content type checking finer grain with a content type resolver so that it only grabs Android XML files and not all XML files.  It is also defined wrong in the existing Content Type, as it isn't a sub category of the XML content type, but it's own content type looking at *.xml extensions.  That is a separate but related issue I need to address on the project.

The way they got around the issue to force that the Android xml formatter would take precedence was to rename their plugin so that it's id, came before the default XML formatter.  Thus their's always is used currently for Source->Format for xml files which is not what we want to happen as it doesn't play nice with existing plugins.

Dave

On 3/15/15 11:52 AM, David M Williams wrote:
Does the android xml have it's own "content type"? If not, could it? (i.e. needs "quick and easy detection, ideally based on only a few lines of input).

While it's a VERY old memory, I *think* that's how formatter is currently chosen?  

And, yes, "priority" was often seen as solving problems, but there were concerns about how that's work "in the wild" -- you know, everyone "wants highest priority". :)
(But, I'm not saying something couldn't be done ... just not sure.





From:        David Carver <d_a_carver@xxxxxxxxx>
To:        wtp-dev@xxxxxxxxxxx,
Date:        03/15/2015 11:36 AM
Subject:        Re: [wtp-dev] Choose XML Formatter based on Priority
Sent by:        wtp-dev-bounces@xxxxxxxxxxx




It probably could be added to the existing formatter.  They just wanted the attributes to line up differently in many cases.  I'll have to do a comparison between the two to see what are the main functional differences.

Dave

On 3/14/15 10:01 AM, Max Rydahl Andersen wrote:
+1 for finding a way to do this better. 

Btw. What is so special about the android xml to not just be handled by a normal xml formatter?

Could it be fixed by improving the default xml formatter ?

/max

http://about.me/maxandersen


On 13 Mar 2015, at 18:48, David Carver <
d_a_carver@xxxxxxxxx> wrote:

In the Andmore project we have an inheritted the ADT XML formater.  Right now it is taking precedence over any other formatter.  So when you try to do a Source->Format on a project and you have the ADT plugins installed, the XML Formatter from ADT is taking over for all XML files.   I checked the extension point, and there doesn't seem to be a way to specify that particular XML formatters should affect only particular files or content types.  This works correctly though if you format within an Editor as the editors control what formatter is used.

I have an open feature request to extend this mechanism so we can get finer grained control and only have the Andmore formatter affect the andmore related files.

https://bugs.eclipse.org/bugs/show_bug.cgi?id=460055

Dave

_______________________________________________
wtp-dev mailing list

wtp-dev@xxxxxxxxxxx
To change your delivery options, retrieve your password, or unsubscribe from this list, visit

https://dev.eclipse.org/mailman/listinfo/wtp-dev


_______________________________________________
wtp-dev mailing list
wtp-dev@xxxxxxxxxxx
To change your delivery options, retrieve your password, or unsubscribe from this list, visit
https://dev.eclipse.org/mailman/listinfo/wtp-dev
_______________________________________________
wtp-dev mailing list
wtp-dev@xxxxxxxxxxx
To change your delivery options, retrieve your password, or unsubscribe from this list, visit
https://dev.eclipse.org/mailman/listinfo/wtp-dev


_______________________________________________
wtp-dev mailing list
wtp-dev@xxxxxxxxxxx
To change your delivery options, retrieve your password, or unsubscribe from this list, visit
https://dev.eclipse.org/mailman/listinfo/wtp-dev


Back to the top