Re: [wtp-dev] Building JSDT in Eclipse

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index] [List Home]

Re: [wtp-dev] Building JSDT in Eclipse

From: Mickael Istria <mistria@xxxxxxxxxx>
Date: Tue, 10 Jun 2014 09:35:56 +0200
Delivered-to: wtp-dev@xxxxxxxxxxx
List-archive: <https://dev.eclipse.org/mailman/private/wtp-dev>
List-help: <mailto:wtp-dev-request@eclipse.org?subject=help>
List-subscribe: <https://dev.eclipse.org/mailman/listinfo/wtp-dev>, <mailto:wtp-dev-request@eclipse.org?subject=subscribe>
List-unsubscribe: <https://dev.eclipse.org/mailman/options/wtp-dev>, <mailto:wtp-dev-request@eclipse.org?subject=unsubscribe>
User-agent: Mozilla/5.0 (X11; Linux x86_64; rv:24.0) Gecko/20100101 Thunderbird/24.5.0

On 06/06/2014 07:49 PM, Pieter Peeters wrote:

I did as you suggested and it works! :) Also, I fixed the bug that annoyed me, so now I would like to submit a gerrit review. Should I base my commits on top of the gerrit master branch? It is not very clear how this works, and the documentation does not help me a lot.

Yes, your change should ideally based on top of master. Then you can push it to Gerrit "refs/for/master" branch. This will create a new Gerrit review entry.

--
Mickael Istria
Eclipse developer at JBoss, by Red Hat
My blog - My Tweets

References:
- [wtp-dev] Building JSDT in Eclipse
  - From: Pieter Peeters
- Re: [wtp-dev] Building JSDT in Eclipse
  - From: Mickael Istria
- Re: [wtp-dev] Building JSDT in Eclipse
  - From: Pieter Peeters

Prev by Date: Re: [wtp-dev] Building JSDT in Eclipse
Next by Date: Re: [wtp-dev] Building JSDT in Eclipse
Previous by thread: Re: [wtp-dev] Building JSDT in Eclipse
Next by thread: Re: [wtp-dev] Building JSDT in Eclipse
Index(es):
- Date
- Thread

Breadcrumbs