[wtp-dev] Fwd: [webtools.jsdt.core] Fix switch statement error (#3)

[Wayne Beaton <wayne@xxxxxxxxxxx>]

FYI,

Wayne

http://wiki.eclipse.org/Development_Resources/Handling_Git_Contributions

-------- Original Message --------

Subject:	[webtools.jsdt.core] Fix switch statement error (#3)
Date:	Thu, 02 May 2013 00:07:51 -0700
From:	ZuluS <notifications@xxxxxxxxxx>
Reply-To:	eclipse/webtools.jsdt.core <reply+i-13879542-01c8fba6780db13f5118d24efa482bb66ab3c03b-555569@xxxxxxxxxxxxxxxx>
To:	eclipse/webtools.jsdt.core <webtools.jsdt.core@xxxxxxxxxxxxxxxxxx>

Fix errors on this switch:

switch (item) {
case 1/2:
case 1/3:
}

Problem:
Constant.computeConstantOperationDIVIDE if detect int on left and right side always return IntConstant, what is ok Java but wrong on _javascript_

---

You can merge this Pull Request by running

  git pull https://github.com/zulus/webtools.jsdt.core switchfix

Or view, comment on, or merge it at:

  https://github.com/eclipse/webtools.jsdt.core/pull/3

Commit Summary

• Fix switch statement error

File Changes

• M bundles/org.eclipse.wst.jsdt.core/src/org/eclipse/wst/jsdt/internal/compiler/ast/SwitchStatement.java (9)
• M bundles/org.eclipse.wst.jsdt.core/src/org/eclipse/wst/jsdt/internal/compiler/impl/Constant.java (8)

Patch Links:

• https://github.com/eclipse/webtools.jsdt.core/pull/3.patch
• https://github.com/eclipse/webtools.jsdt.core/pull/3.diff

--
Wayne Beaton
Director of Open Source Projects, The Eclipse Foundation
Learn about Eclipse Projects