Skip to main content

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index] [List Home]
Re: [wtp-dev] How do we get JSDT issues that have patches actually fixed ?

Hi Max,

Thanks for bringing these issues up. I will take a look at issues related to jsdt parser and see what if the patches can apply to vjet. We can leverage the ecmascript test suite when making changes to the ast parser.

Can you be more specific on this issue?

> the lack of handling semi-colons properly

Thanks,

Justin

Sent from my iPad

On Jan 29, 2013, at 1:58 AM, Max Rydahl Andersen <max.andersen@xxxxxxxxxx> wrote:

> Hi guys,
> 
> We got a bunch of fixes/patches submitted in bugzilla trying to get JSDT not fail on common available javascript libraries;
> especially in context of libraries popular in mobile tools.
> 
> Similar errors still exist in VJET which has its own fork of JDST so i'm cc'ing vjet-dev on this topic too.
> 
> Some of these issues and their patches are close to a year old...time to get these pushed in IMO.
> 
> https://bugs.eclipse.org/bugs/show_bug.cgi?id=366247 - NPE in CompilationUnitBinding#sourceMethod() (triggered by birt and other js libraries) 
> https://bugs.eclipse.org/bugs/show_bug.cgi?id=356446 - [exceptions] Errors running builder 'JavaScript Validator' on project with ArrayIndexOutOfBoundsException (Also fixes #344745)
> https://bugs.eclipse.org/bugs/show_bug.cgi?id=344745 - [search] ArrayIndexOutOfBoundsException in DiskIndex during problem detection 
> https://bugs.eclipse.org/bugs/show_bug.cgi?id=350693 - [exceptions][parser] ArrayIndexOutOfBoundsException in Parser#consumeEmptyStatement on a javascript file when building project
> https://bugs.eclipse.org/bugs/show_bug.cgi?id=357353 - ArrayIndexOutOfBoundsException in UnconditionalFlowInfo#markAsDefinitelyNonNull() with FieldReference 
> https://bugs.eclipse.org/bugs/show_bug.cgi?id=349020 - [validation] Eclipse complains about jquery minified JS files 
> 
> These makes it much more tolerable to use JSDT with javascript libraries.
> 
> One issue we haven't found a way to solve yet is the lack of handling semi-colons properly - but would love to see it fixed but lack the info on how to update/modify the parser.
> 
> But lets start with what we already got patches for - how do we get these issues with already existing patches fixed for Kepler ? 
> 
> /max
> _______________________________________________
> wtp-dev mailing list
> wtp-dev@xxxxxxxxxxx
> https://dev.eclipse.org/mailman/listinfo/wtp-dev


Back to the top