[
Date Prev][
Date Next][
Thread Prev][
Thread Next][
Date Index][
Thread Index]
[
List Home]
|
Re: [wtp-dev] Upcoming changes to the Java Facet
|
yes, but I burned my fingers too much on explaining to devs that just because
I use == in such a case doesn't mean you can use == in others.
Thus I prefer use equals/compareTo whenever possible. Less trouble when
copy/pasted/mutated :)
/max
On Jun 14, 2010, at 17:36, Konstantin Komissarchik wrote:
> Yes, you can use .equals instead of == on Facet and FacetVersion instances,
> but that doesn't do anything special as architecturally these objects are
> singletons so object identity is sufficient.
>
> - Konstantin
>
>
> -----Original Message-----
> From: wtp-dev-bounces@xxxxxxxxxxx [mailto:wtp-dev-bounces@xxxxxxxxxxx] On
> Behalf Of Andersen Max
> Sent: Monday, June 14, 2010 12:58 AM
> To: General discussion of project-wide or architectural issues.
> Subject: Re: [wtp-dev] Upcoming changes to the Java Facet
>
> thanks - just to clarify, the paragraph says use == or compareTo ...isn't
> equals ok too on the Facet and Version instances ?
>
> /max
>
> On Jun 8, 2010, at 16:52, Konstantin Komissarchik wrote:
>
>> Sure. Added a paragraph to the wiki.
>>
>> - Konstantin
>>
>>
>> -----Original Message-----
>> From: wtp-dev-bounces@xxxxxxxxxxx [mailto:wtp-dev-bounces@xxxxxxxxxxx] On
>> Behalf Of Andersen Max
>> Sent: Tuesday, June 08, 2010 3:57 AM
>> To: General discussion of project-wide or architectural issues.
>> Subject: Re: [wtp-dev] Upcoming changes to the Java Facet
>>
>> Hi,
>>
>> sorry for reopening an old thread but we just bumped into this change in
> our
>> codebase.
>>
>> May I suggest this subtle change is covered on
>> http://wiki.eclipse.org/New_Help_for_Old_Friends_V with
>> example of what API to use instead of the very common string comparison
> for
>> facet versions ?
>>
>> /max
>>
>> On Jan 5, 2010, at 23:24, Konstantin Komissarchik wrote:
>>
>>> I want to alert the community regarding a few upcoming changes to the
> Java
>> Facet. All of the these changes are detailed in the following Bugzilla
>> entries. Please put any comments in Bugzilla rather than on this e-mail
>> thread.
>>>
>>> Java Facet should utilize Execution Environment when updating Java Build
>> Path
>>> https://bugs.eclipse.org/bugs/show_bug.cgi?id=298712
>>>
>>> Support Java 7 in Java facet and Standard JRE runtime component
>>> https://bugs.eclipse.org/bugs/show_bug.cgi?id=298904
>>>
>>> Change Java Facet id from "jst.java" to "java"
>>> https://bugs.eclipse.org/bugs/show_bug.cgi?id=298905
>>>
>>> Change Java Facet version for 5.0/6.0 to 1.5/1.6
>>> https://bugs.eclipse.org/bugs/show_bug.cgi?id=298906
>>>
>>> Thanks,
>>>
>>> - Konstantin
>>> _______________________________________________
>>> wtp-dev mailing list
>>> wtp-dev@xxxxxxxxxxx
>>> https://dev.eclipse.org/mailman/listinfo/wtp-dev
>>
>> _______________________________________________
>> wtp-dev mailing list
>> wtp-dev@xxxxxxxxxxx
>> https://dev.eclipse.org/mailman/listinfo/wtp-dev
>>
>> _______________________________________________
>> wtp-dev mailing list
>> wtp-dev@xxxxxxxxxxx
>> https://dev.eclipse.org/mailman/listinfo/wtp-dev
>
> _______________________________________________
> wtp-dev mailing list
> wtp-dev@xxxxxxxxxxx
> https://dev.eclipse.org/mailman/listinfo/wtp-dev
>
> _______________________________________________
> wtp-dev mailing list
> wtp-dev@xxxxxxxxxxx
> https://dev.eclipse.org/mailman/listinfo/wtp-dev
