[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index] [List Home]
[wtp-dev] FW: IP Log issues due to project re-org

FYI... The IP logs are acceptable as they are unless you have a reason to
doubt than any of the listed individuals have ever committed code to the
project (before or after the re-org).

- Konstantin


-----Original Message-----
From: Konstantin Komissarchik [mailto:konstantin.komissarchik@xxxxxxxxxx] 
Sent: Monday, May 04, 2009 1:49 PM
To: 'Wayne Beaton'
Cc: 'Anne Jacko'; 'emo-ip-team@xxxxxxxxxxx'; 'David M Williams'
Subject: RE: IP Log issues due to project re-org

Thanks, Wayne.

> Do you have any reason to doubt what Dash is reporting?

Nope. The listed committers are there due project re-org. All of these
individuals made commits to files that later became part of WTP Common when
WTP was still a single project. The CVS history tracks back through the
re-org to present the full picture, but it looks like the committer database
does not.

> The IP Team tells me that they'll accept a log with "not a current 
> committer" beside the name. Unless I've missed something (which is 
> certainly possible), you're done.

Great. That's the answer that I was looking for. :)

- Konstantin


-----Original Message-----
From: Wayne Beaton [mailto:wayne@xxxxxxxxxxx] 
Sent: Monday, May 04, 2009 1:29 PM
To: Konstantin Komissarchik
Cc: 'Anne Jacko'; emo-ip-team@xxxxxxxxxxx; 'David M Williams'
Subject: Re: IP Log issues due to project re-org

According to the documentation [1]:

> The Committers section of the IP Log uses two information sources to 
> generate the two lists:
>
>    1. The list of all committers who have committed code to any of the
>       source repositories from the Commits Explorer
>       <http://dash.eclipse.org/dash/commits/web-app/summary.cgi>. This
>       is the basis of the "Past and Present" list. The commits
>       explorer list is driven by the project meta data |source
>       repository| item(s).
>    2. The list of all past and present committers from the
>       Foundation's internal database of committers and projects.
>       Committers here but not in in the "Past and Present" list are
>       put on the "Never Active" list.
>
The list of names at the bottom (the ones with company affiliation 
displayed) are all listed as current committers in the Foundation database.

The list of names marked with "not a current committer" is just a bunch 
of ids, which means that the information isn't coming out of the 
Foundation database, but rather is from CVS. This leads me me to believe 
that there are actual commits in your CVS component for each of these 
people. A quick walk through Dash [2] confirms this. Do you have any 
reason to doubt what Dash is reporting?

So... to me, the list looks correct. The IP Team tells me that they'll 
accept a log with "not a current committer" beside the name. Unless I've 
missed something (which is certainly possible), you're done.

I think we need to update to the tool to (a) translate the committer id 
into a name, and (b) be more explicit about why the committer is on the 
list (i.e. which of the two reasons).

Wayne

[1]http://wiki.eclipse.org/Development_Resources/Automatic_IP_Log
[2]http://dash.eclipse.org/dash/commits/web-app/summary.cgi?company=y&year=x
&top=webtools&project=webtools.common

Konstantin Komissarchik wrote:
> IP Team,
>
>  
>
> Could you provide some guidance as to what is expected of projects in this
> situation? The wiki describing the IP Log tool just says "contact EMO" in
> this situation. If the database cannot be easily fixed to properly record
> prior committers, are we ok releasing the logs just as they are? 
>
>  
>
> - Konstantin
>
>  
>
> From: Anne Jacko [mailto:emo@xxxxxxxxxxx] 
> Sent: Thursday, April 30, 2009 5:42 PM
> To: Konstantin Komissarchik; emo-ip-team@xxxxxxxxxxx
> Cc: David M Williams; Wayne Beaton
> Subject: Re: IP Log issues due to project re-org
>
>  
>
> Hi Konstantin,
>
>  
>
> We do see this type of error in the IP logs when a top-level project does
> some reorganization. (And BTW, we just changed the code so that instead of
> "???" you now see "(not a current committer)" in that column -- a bit more
> descriptive.)
>
>  
>
> It's possible to exclude committers when using the IP Log tool to correct
> errors but obviously this needs to be done with care. My suggestion would
be
> to contact the IP Team and see if this is the preferred way to deal with
the
> errors, or if they have another suggestion (such as leaving the entire
list
> of committers in there, errors and all, and approving the IP Log anyway
> because the old commits are not a problem).
>
>  
>
> For a long-term solution such as changing the database so that past
> committers on a project are listed and therefore don't show up with errors
> in the IP Log, again, that's a discussion to have with the IP Team, since
> they maintain committer records. Thanks.
>
>  
>
> Anne Jacko
>
> emo@xxxxxxxxxxx
>
>  
>
> On Apr 30, 2009, at 11:43 AM, Konstantin Komissarchik wrote:
>
>
>
>
>
> In reviewing the IP log for WTP sub-projects, we are puzzled about how to
> resolve committers with ??? next to their name. See this log for example:
>
>  
>
> http://www.eclipse.org/projects/ip_log.php?projectid=webtools.common
>
>  
>
> All of these individuals were committers on the unified WTP project before
> it was broken up. When WTP was broken up, they were already not active so
> they did not end up committers on the new project. It looks like the books
> were never updated to account for this. Should the database be updated so
> that all past committers on the unified WTP project are listed in
committer
> history for all of the spawned projects? This would fairly accurately
> reflect the reality of the situation.
>
>  
>
> - Konstantin
>
>  
>
> No virus found in this incoming message.
> Checked by AVG - www.avg.com
> Version: 8.0.238 / Virus Database: 270.12.5/2083 - Release Date: 04/27/09
> 18:00:00
>
>
>   

No virus found in this incoming message.
Checked by AVG - www.avg.com 
Version: 8.0.238 / Virus Database: 270.12.16/2094 - Release Date: 05/03/09
16:51:00