Skip to main content

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index] [List Home]
[wtp-dev] Submission for PMC approval (1.5.1) 158070 - JSPJavaValidator creating/discarding compilation units causes tremendous Java Model listener event notifications


https://bugs.eclipse.org/bugs/show_bug.cgi?id=158070

The JSPJavaValidator is responsible for reporting Javaish errors in JSP files.  To do so, it creates a mini-translation of a JSP, inserts the translated Java source into the JDT model, and runs it through the JDT compiler.  The results from the compiler are translated back into the right offsets in the JSP file as validation messages.  When the Java source is inserted into the JDT model (and then removed), notification is fired from the JDT level and the processing time of the listeners ends up impacting the measured speed of the validator.  In the case mentioned in the bug, there's both a slow listener and a large number of notifications being sent when validating a large project.  The solution developed is to encase the JSPJavaValidator's JDT calls inside of a JDT JavaModelOperation, reducing the many notifications that would have been sent before (two per file for each JSP file) down to one single notification regardless of how many files were validated.

---
Nitin Dahyabhai

Back to the top