Skip to main content

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index] [List Home]
RE: [wtp-dev] Enablement expression support in validator ext point

Vijay,

 

You may want to consider logging deprecation warnings into PDE Error Log when the deprecated extension syntax is detected. The deprecation warning should include the id of the plugin that the deprecated syntax is used in. This way the plugin owner is more likely to become aware that they are using deprecated syntax and will transition to the new syntax more quickly.

 

I have done this for all the syntax that I have deprecated in the faceted project framework.

 

- Konstantin

 


From: wtp-dev-bounces@xxxxxxxxxxx [mailto:wtp-dev-bounces@xxxxxxxxxxx] On Behalf Of Vijay Bhadriraju
Sent: Monday, April 17, 2006 11:07 AM
To: General discussion of project-wide or architectural issues.
Cc: General discussion of project-wide or architectural issues.; wtp-dev-bounces@xxxxxxxxxxx
Subject: Re: [wtp-dev] Enablement _expression_ support in validator ext point

 


Yes, enablement is the recommended way to filter validators based on facets, the facet filters has been deprecated but will continue to work.

Regards, Vijay
_____________________________
Vijay Bhadriraju
Rational Tools, J2EE Tooling
Ph: (919) 486-1898, T/L: 526-1898
Internet: vbhadrir@xxxxxxxxxx

_____________________________


Lawrence Mandel <lmandel@xxxxxxxxxx>
Sent by: wtp-dev-bounces@xxxxxxxxxxx

04/17/2006 12:10 PM

Please respond to
"General discussion of project-wide or architectural issues." <wtp-dev@xxxxxxxxxxx>

To

"General discussion of project-wide or architectural issues." <wtp-dev@xxxxxxxxxxx>

cc

 

Subject

Re: [wtp-dev] Enablement _expression_ support in validator ext point

 

 

 





Hi Vijay,


Is the enablement method now the recommended way to restrict based on facets? Has the facet filters support been deprecated?


Thanks,


Lawrence Mandel

Software Developer
IBM Rational Software
Phone: 905 - 413 - 3814   Fax: 905 - 413 - 4920
lmandel@xxxxxxxxxx

Vijay Bhadriraju <vbhadrir@xxxxxxxxxx>
Sent by: wtp-dev-bounces@xxxxxxxxxxx

04/16/2006 10:52 PM

Please respond to
"General discussion of project-wide or architectural issues." <wtp-dev@xxxxxxxxxxx>

To

wtp-dev@xxxxxxxxxxx

cc

 

Subject

[wtp-dev] Enablement _expression_ support in validator ext point

 

 

 






The support for enablement _expression_ as shown below has been added to the validator extension point. The facet filters support added in the validator ext point in addition to natures  did not scale very well and additional requirements from some extended teams drove the need for the enablement support which scales very well.  This _expression_ support covers all the combinations that the
FacetedProjectPropertyTester provides as this is the tester class that is used under the covers for property and value strings.

The ejb validator is changed to use this support instead of facet filters


<extension

       id="EJBValidator"

       name="%EJB_VALIDATOR"

       point="org.eclipse.wst.validation.validator">

    <validator>

       <enablement>

               <and>

                      <test property="org.eclipse.wst.common.project.facet.core.projectFacet" value="jst.java"/>

                        <test property="org.eclipse.wst.common.project.facet.core.projectFacet" value="jst.ejb"/>

                 </and>

         </enablement>
       <filter

             objectClass="org.eclipse.core.resources.IFile"

             nameFilter="ejb-jar.xml">

       </filter>

       <filter

             objectClass="org.eclipse.core.resources.IFile"

             nameFilter="*.class">

       </filter>

       <filter

             objectClass="org.eclipse.core.resources.IFile"

             nameFilter="*.java">

       </filter>

       <helper

             class="org.eclipse.jst.j2ee.internal.ejb.workbench.validation.EJBHelper">

       </helper>

       <dependentValidator

             depValValue="true">

       </dependentValidator>

       <markerId

             markerIdValue="EJBValidatorMarker">

       </markerId>

       <run

             class="org.eclipse.jst.j2ee.internal.ejb.workbench.validation.UIEjbValidator">

       </run>

    </validator>

 </extension>


The facet filters support still exists and works in the validator ext point even though it is redundant with this enablement support. The reason it is still supported is for the fact that we are not supposed to break any internal api also at this point for 1.5. Validators using facet filters will continue to work as is and the any validators that need the enablement _expression_ support can migrate.


Regards, Vijay
_____________________________
Vijay Bhadriraju
Rational Tools, J2EE Tooling
Ph: (919) 486-1898, T/L: 526-1898
Internet: vbhadrir@xxxxxxxxxx

_____________________________
_______________________________________________
wtp-dev mailing list
wtp-dev@xxxxxxxxxxx
https://dev.eclipse.org/mailman/listinfo/wtp-dev

_______________________________________________
wtp-dev mailing list
wtp-dev@xxxxxxxxxxx
https://dev.eclipse.org/mailman/listinfo/wtp-dev

_______________________________________________________________________
Notice:  This email message, together with any attachments, may contain
information  of  BEA Systems,  Inc.,  its subsidiaries  and  affiliated
entities,  that may be confidential,  proprietary,  copyrighted  and/or
legally privileged, and is intended solely for the use of the individual
or entity named in this message. If you are not the intended recipient,
and have received this message in error, please immediately return this
by email and then delete it.

Back to the top