Skip to main content

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index] [List Home]
[wtp-dev] Requesting PMC approval: IDataModel API change request for R1.5


details below...

- Chuck

Rational J2EE Tooling Team Lead
IBM Software Lab - Research Triangle Park, NC
Email:  cbridgha@xxxxxxxxxx
Phone: 919-254-1848 (T/L: 444)

----- Forwarded by Chuck Bridgham/Raleigh/IBM on 03/30/2006 11:51 AM -----
Chuck Bridgham/Raleigh/IBM

03/29/2006 11:28 AM

To
wtp-pmc@xxxxxxxxxxx
cc
Jason A Sholl/Raleigh/IBM@IBMUS
Subject
IDataModel API change request




Hi,

I am forwarding this request to the PMC as the note below describes three method changes(removal) to two API classes.

org.eclipse.wst.common.frameworks.datamodel.AbstractDataModelOperation.getDataModelIDs()
org.eclipse.wst.common.frameworks.datamodel.AbstractDataModelOperation.getPreOperations()

org.eclipse.wst.common.frameworks.datamodel.AbstractDataModelOperation.getPostOperations()


org.eclipse.wst.common.frameworks.datamodel.IDataModelOperation.getDataModelIDs()

org.eclipse.wst.common.frameworks.datamodel.IDataModelOperation.getPreOperations()

org.eclipse.wst.common.frameworks.datamodel.IDataModelOperation.getPostOperations()


Jason has done an exhaustive search of WTP and adopters, and has found no breakage.    Last year the two competing operation frameworks were combined, and these methods were added,
but never used externally.   After some additional internal changes for the defects listed below, the need for these methods is gone.

What should be our strategy?    deprecation? removal?

Jason can provide more detail of this change.....

- Chuck

Rational J2EE Tooling Team Lead
IBM Software Lab - Research Triangle Park, NC
Email:  cbridgha@xxxxxxxxxx
Phone: 919-254-1848 (T/L: 444)

----- Forwarded by Chuck Bridgham/Raleigh/IBM on 03/29/2006 11:20 AM -----
Jason A Sholl/Raleigh/IBM@IBMUS
Sent by: wtp-dev-bounces@xxxxxxxxxxx

03/28/2006 04:37 PM

Please respond to
"General discussion of project-wide or architectural issues."

To
wtp-dev@xxxxxxxxxxx
cc
Subject
[wtp-dev] IDataModel framework changes coming.






If you are not using the IDataModel framework, then there is no need to continue reading this note.


In order to fix bugs https://bugs.eclipse.org/bugs/show_bug.cgi?id=125338 and https://bugs.eclipse.org/bugs/show_bug.cgi?id=118853, some api changes are necessary.  Though these changes are potentially breaking, I don't believe there was any usage outside the internal classes I have already cleaned up.  If there are no objections, I would like to put these changes in this week's integration build.


The following methods will be removed from the public API, because they no longer make sense:


org.eclipse.wst.common.frameworks.datamodel.AbstractDataModelOperation.getDataModelIDs()

org.eclipse.wst.common.frameworks.datamodel.AbstractDataModelOperation.getPreOperations()

org.eclipse.wst.common.frameworks.datamodel.AbstractDataModelOperation.getPostOperations()


org.eclipse.wst.common.frameworks.datamodel.IDataModelOperation.getDataModelIDs()

org.eclipse.wst.common.frameworks.datamodel.IDataModelOperation.getPreOperations()

org.eclipse.wst.common.frameworks.datamodel.IDataModelOperation.getPostOperations()


Substantial changes are necessary in various internal classes which include the removal of the following classes:


org.eclipse.wst.common.frameworks.internal.DataModelManager

org.eclipse.wst.common.frameworks.internal.OperationListener

org.eclipse.wst.common.frameworks.internal.OperationManager


org.eclipse.wst.common.frameworks.internal.datamodel.ExtendableOperationImpl


I have cleaned up all compile and runtime errors in the following plugins:


org.eclipse.wst.common.frameworks

org.eclipse.wst.common.frameworks.ui

org.eclipse.wst.common.modulecore

org.eclipse.wst.common.tests

org.eclipse.wst.common.tests.ui

org.eclipse.wst.web.ui


I did not find any references to any of the deleted classes or methods anywhere in WTP.  Lastly, I ran the api tool and am following up with the owners to determine whether they are legitimate concerns.  If anyone has concerns about these changes please let me know.


Thank you,

Jason A. Sholl
jsholl@xxxxxxxxxx
919-543-0011 (t/l 441-0011)
_______________________________________________
wtp-dev mailing list
wtp-dev@xxxxxxxxxxx
https://dev.eclipse.org/mailman/listinfo/wtp-dev

Back to the top