Skip to main content

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index] [List Home]
[wtp-dev] 124566 Extended Data Model Operations running twice


Is anyone using partial operation execution supported by OperationManager from DataModelWizards?  This is the support for partially executing an operation tree when changing to a new page, undoing any partial executions when going back, and undoing the entire operation stack on a cancel.  I don't think anyone is using this, but if you are, please speak up ASAP here: https://bugs.eclipse.org/bugs/show_bug.cgi?id=124566

Extended DataModel Operations are being executed twice; once from the OperationManager, and once from ExtendeableOperationImpl.  This problem has only been exposed through DataModelWizards, but likely exists anywhere an OperationManager is used to execute operations.  The proper fix is to merge the ExtendedOperations support provided by OperationManager and ExtendableOperationImpl and integrate it tightly to the Operation.  The problem is this is a rather large change to put in 1.0.1.  So, in the short term, if nobody is using the OperationManager (I don't beleive anyone currently is), I propose disconnecting the OperationManager from DataModelWizard in 1.0.1, and relying on ExtendableOperationImpl for executing all extended operations.  Doing this would revert DataModelOperations back to their original implementation and is low risk.  This disconnection would only go into 1.0.1.  The proper fix will be done in 1.5.

Thank you,

Jason A. Sholl
jsholl@xxxxxxxxxx
919-543-0011 (t/l 441-0011)

Back to the top