[
Date Prev][
Date Next][
Thread Prev][
Thread Next][
Date Index][
Thread Index]
[
List Home]
|
Re: [wtp-dev] Status on RC1 build - assuming delayed 24 hours.
|
For bug 103065 - WSExplorer does not
show any input field in the form view, I believe this is a bug in the WSDL
model. The WSDL model has some code that checks whether the "parameterOrder"
attribute exists on a WSDL operation element or not. If this attribute
exists, it will set the WSDL part ordering base on the value of this attribute.
Problem is, it's using the following code to get the attribute:
changedElement.getAttribute("parameterOrder");
According to the javadoc from w3c.dom.Element,
the getAttribute(...) method will return "" even if the attribute
does not exist. As a result, the WSDL model thought a part ordering was
specified even if it is not. The fix is to check the existence of the attribute
using the hasAttribute(...) method before getting its value. It's a low
risk fix. I've attached a patch. Craig/Kihup/Keith, please review and commit/release
if you agree to the fix.
Thanks,
Jeff
Arthur Ryman/Toronto/IBM@IBMCA
Sent by: wtp-dev-bounces@xxxxxxxxxxx
07/13/2005 11:17 PM
|
Please respond to
"General discussion of project-wide or architectural issues." |
|
|
To
| "General discussion
of project-wide or architectural issues." <wtp-dev@xxxxxxxxxxx>
|
|
cc
|
|
|
Subject
| Re: [wtp-dev] Status on RC1
build - assuming delayed 24 hours. |
|
Chris,
We need to wait for legal approval for 98340 which may come on Friday,
so let's not hold up RC1 for that.
What is your outlook for resolving 103065, 103653, 102867? Can you fix
these by 8pm Thursday?
Arthur Ryman,
Rational Desktop Tools Development
phone: +1-905-413-3077, TL 969-3077
assistant: +1-905-413-2411, TL 969-2411
fax: +1-905-413-4920, TL 969-4920
mobile: +1-416-939-5063, text: 4169395063@xxxxxxx
intranet: http://labweb.torolab.ibm.com/DRY6/
Chris Brealey/Toronto/IBM@IBMCA
Sent by: wtp-dev-bounces@xxxxxxxxxxx
07/13/2005 03:34 PM
|
Please respond to
"General discussion of project-wide or architectural issues." |
|
|
To
| "General discussion
of project-wide or architectural issues." <wtp-dev@xxxxxxxxxxx>
|
|
cc
|
|
|
Subject
| Re: [wtp-dev] Status on RC1
build - assuming delayed 24 hours. |
|
Arthur,
thanks. I've committed and released three bug fixes just now, leaving us
with the following bugs we are still working on for WTP 0.7. Some of these
may be more deferrable (eg. Axis on Geronimo?) than others (eg. Axis 1.2?).
As always, the WTP community is more than welcome to chime in with opinions
on which bugs are, or are not, critical for 0.7 - and that can include
bugs that are not on this list.
BTW: At an absolute minimum, bugs 103065, 103653, 98340, 102867 would
be cause for me to vote "no".
jst.ws
100677 blo 1.0
M6 Axis deploy problem with Geronimo server
103065 blo 1.0
M6 WSExplorer does not show any input field
in the form view
103653 cri 1.0
M6 StartServerCommand should check getServerRestartState()
b...
98340 maj 1.0 M6
Support Axis 1.2 instead of Axis 1.1
103068 maj 1.0
M6 EAR project field not pre-filled.
wst.ws
102867 cri 1.0
M6 Can't create a simple top down web service
using WTP0.7 w...
103405 maj 1.0
M6 Check in translated property files for the
WSExplorer
Cheers - CB.
Chris Brealey
Senior Advisory Technical Manager, Rational Java Web Services, IBM Canada
Ltd.
D3-275, D3/ENX/8200/MKM, 8200 Warden Avenue, Markham, Ontario, Canada,
L6G 1C7
cbrealey@xxxxxxxxxx, 905.413.6038, tieline:969.6038, fax:905.413.4920
Arthur Ryman/Toronto/IBM@IBMCA
Sent by: wtp-dev-bounces@xxxxxxxxxxx
07/13/2005 12:06 PM
|
Please respond to
"General discussion of project-wide or architectural issues." |
|
|
To
| "General discussion
of project-wide or architectural issues." <wtp-dev@xxxxxxxxxxx>
|
|
cc
| wtp-dev@xxxxxxxxxxx, wtp-dev-bounces@xxxxxxxxxxx
|
|
Subject
| Re: [wtp-dev] Status on RC1
build - assuming delayed 24 hours. |
|
David,
Agreed. We have inadequate time for testing today. Also, Chris said he
needed more time for fixes. Let's reset the clock by 1 day.
Chris - go ahead and release your fixes today.
Arthur Ryman,
Rational Desktop Tools Development
phone: +1-905-413-3077, TL 969-3077
assistant: +1-905-413-2411, TL 969-2411
fax: +1-905-413-4920, TL 969-4920
mobile: +1-416-939-5063, text: 4169395063@xxxxxxx
intranet: http://labweb.torolab.ibm.com/DRY6/
David M Williams <david_williams@xxxxxxxxxx>
Sent by: wtp-dev-bounces@xxxxxxxxxxx
07/13/2005 11:13 AM
|
Please respond to
"General discussion of project-wide or architectural issues." |
|
|
To
| wtp-dev@xxxxxxxxxxx
|
|
cc
|
|
|
Subject
| [wtp-dev] Status on RC1 build
- assuming delayed 24 hours. |
|
Since I have not heard from Naci or Lawrence on cause or potential solutions
to the build hangs, I have backed out to the previous version of resolver.cache
to attempt to revert the "dialog popup" issues until those can
be solved.
However, since the earliest this build would be available (even if this
attempt works) is 1 PM Eastern, I do not think it is a quality process
to then expect team leads to
test and vote by 4 PM as originally planned.
In short, I am assuming RC1 is delayed by at least 24 hours (4 PM Thursday)
as we work through these build issues (and collect photos of comitters
in clown noses :)
[P.S. I did just hear from Lawrence, and he believes the previous version
which is building now should get past the hang problem -- then we'll see
what else pops up (I couldn't resist that pun :) ]
_______________________________________________
wtp-dev mailing list
wtp-dev@xxxxxxxxxxx
https://dev.eclipse.org/mailman/listinfo/wtp-dev
_______________________________________________
wtp-dev mailing list
wtp-dev@xxxxxxxxxxx
https://dev.eclipse.org/mailman/listinfo/wtp-dev
_______________________________________________
wtp-dev mailing list
wtp-dev@xxxxxxxxxxx
https://dev.eclipse.org/mailman/listinfo/wtp-dev
_______________________________________________
wtp-dev mailing list
wtp-dev@xxxxxxxxxxx
https://dev.eclipse.org/mailman/listinfo/wtp-dev
Index: src-wsdl/org/eclipse/wst/wsdl/internal/impl/OperationImpl.java
===================================================================
RCS file: /home/webtools/wst/components/wsdl/plugins/org.eclipse.wst.wsdl/src-wsdl/org/eclipse/wst/wsdl/internal/impl/OperationImpl.java,v
retrieving revision 1.3
diff -u -r1.3 OperationImpl.java
--- src-wsdl/org/eclipse/wst/wsdl/internal/impl/OperationImpl.java 21 Jun 2005 18:16:33 -0000 1.3
+++ src-wsdl/org/eclipse/wst/wsdl/internal/impl/OperationImpl.java 14 Jul 2005 04:34:51 -0000
@@ -943,12 +943,15 @@
setName(name);
}
- String parameterOrder = changedElement.getAttribute("parameterOrder");
- if (parameterOrder != null)
+ if (changedElement.hasAttribute("parameterOrder"))
{
- String[] array = parameterOrder.split(" ");
- List l = Arrays.asList(array);
- setParameterOrdering(l);
+ String parameterOrder = changedElement.getAttribute("parameterOrder");
+ if (parameterOrder != null)
+ {
+ String[] array = parameterOrder.split(" ");
+ List l = Arrays.asList(array);
+ setParameterOrdering(l);
+ }
}
}
