Re: [vtp-dev] Race condition in application properties settings

[Trip Gilman <trip@xxxxxxxxxxxxxxx>]

Title: Re: [vtp-dev] Race condition in application properties settings

Thanks Tom,

    I moved the synchronized in the loadBuildPath to the method declaration and added your suggestion to storeConfig.  Good find, and I appreciate you posting it.

Trip Gilman


On 4/16/09 9:45 AM, "Johnson, Tom" <tom_johnson@xxxxxxxxxxxxxx> wrote:

I believe that I found a race condition when configuring application properties. This is causing the configuration to sometimes lose data such as the language disappears when you change the media defaults.
 
It appears that when you update the application media defaults and then press OK that org.eclipse.vtp.desktop.projects.core.internals.VoiceToolsDesignProject method storeConfig() is trying to update the .buildPath file at the same time as org.eclipse.vtp.desktop.editors.core.impl.ApplicationEditor method resourceChanged(). This can lead to elements disappearing from .buildPath.
 
The fix I put in  (on my copy of the baseline) was to synchronize the storeConfig() method in org.eclipse.vtp.desktop.projects.core.internals.VoiceToolsDesignProject so that it now looks like this:
       public synchronized void storeConfig()
 
That seems to fix the issue.
 
 

 

---

_______________________________________________
vtp-dev mailing list
vtp-dev@xxxxxxxxxxx
https://dev.eclipse.org/mailman/listinfo/vtp-dev