| RE: [vtp-dev] VTP Tellme launcher and Skype v 2.5 -- Issue now understood |
|
Ealier I mentioned the existence of a new
response from Skype CALL nnn STATUS UNPLACED. That is the culprit. Skype has a convention that if you send a
command with a string “#somestring” prepended, then the response to
THAT command would also be prepended with “#somestring”. That
allows one to be sure which string coming from the Skype client is the response
to that command. So, the Tellme launcher initiates the call
with “#tellme CALL +99008358965”, and up to now, the response has
always been “#tellme CALL nnn STATUS ROUTING”. So the launcher
actually matches that string to extract the Skype call number, nnn, which is
then used to communicate with Skype about that call. Now, the response from Skype is “#tellme
CALL nnn STATUS UNPLACED”, and “#tellme CALL nnn STATUS ROUTING”
never happens. (The routing message happens, but without the #tellme prefix.) That
is the issue with Skype 2.5. The fix should be pretty simple: Change the code final Pattern
initial = Pattern .compile("^#tellme
CALL (\\d+) STATUS ROUTING"); //$NON-NLS-1$ in SkypeCall.java to final Pattern
initial = Pattern .compile("^#tellme
CALL (\\d+) STATUS"); //$NON-NLS-1$ If someone wants to file an appropriate
bug for this, and make the change, I would be grateful. I don’t have my
environment set up to do this properly, and I am not going to have time to do
it. -- Mike From:
vtp-dev-bounces@xxxxxxxxxxx [mailto:vtp-dev-bounces@xxxxxxxxxxx] On Behalf Of Well, I am going to have to eat my words
almost as soon as I said them. When I turned back to the VTP window, I
see a dialog that says call failed, did not connect in 60 seconds. I happen to know that it *did* connect, and I heard the voice application
on Studio. The debug output also shows the connection happened. Messages flow
by fast and furious. When I reviewed the code and the debug
log, I cannot see why the message would happen. When the Skype command to start
the call is sent, the code sets a 60-second timer, and waits on a synchronizing
object. If a Skype status message happens that says “INPROGRESS”,
or “FAILED” during that 60 seconds, the wait is ended, and the
message does not happen. In this case, the INPROGRESS status occurred *3* seconds into the interval, yet it was
not recognized apparently. I *did*
notice that I did not get any log from Tellme, but if the code thought the
connection did not happen, it would not go get the (nonexistent) log. -- Mike From:
vtp-dev-bounces@xxxxxxxxxxx [mailto:vtp-dev-bounces@xxxxxxxxxxx] On Behalf Of All – I found a few minutes to give the new Skype version 2.5 a
try with the VTP. It works flawlessly for me. No problem whatsoever. The debug logs show me that the new Skype is quite a bit
“chattier” than previously. There are lots more status messages.
There is a new call state called “UNPLACED”, which comes out before
the call is established. Now duration is sent every second, instead of just at
the end. But none of that matters to the DLL. After it connects, it simply
moves strings, no matter what they are. And the launcher uses only a very very
limited set of Skype commands – basically it places the call and waits
for it to finish. No groups, no chat, no voicemail, no sms, no user info, just
call and end. The new users who reported failure – were they
starting from clean new installations of Skype and VTP? Did they see the Skype
dialog the very first time where one has to click on a radio button and then OK
to tell Skype it is alright for that application to connect to it? If they saw
it, did they answer the question? (I would show you a picture of the dialog,
but once you have answered yes, it is not possible to make it appear.) That is the only thing that I can think of that might result
in failure – and that is only the very *first*
time. After the first time, Skype remembers it is OK. -- Mike |