[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index] [List Home]
Re: [virgo-dev] org.eclipse.virgo.web.properties duplicated

Just catching up after vacation…

The web properties file in config is indeed a relic and should be deleted. It certainly is part of the Tomcat web plan and should be.

Raised: https://bugs.eclipse.org/bugs/show_bug.cgi?id=355473

Regards,
Glyn

On 12 Aug 2011, at 17:54, Kapukaranov, Borislav wrote:

> A clean-up of that folder makes sense. Everything was in there before, because there was just one ConfigAdmin and each configuration was poured in it.
> Now probably it is more natural to have properties deployed along with those requiring them, assuming that's outside the kernel region.
> 
> But if we want to take that direction we have to be careful not to create too many properties locations, as that will be confusing too, just /config and /repository is ok I guess.
> 
> Best Regards
> Borislav
> 
> -----Original Message-----
> From: virgo-dev-bounces@xxxxxxxxxxx [mailto:virgo-dev-bounces@xxxxxxxxxxx] On Behalf Of Dmitry Sklyut
> Sent: Friday, August 12, 2011 7:30 PM
> To: Virgo Project
> Subject: Re: [virgo-dev] org.eclipse.virgo.web.properties duplicated
> 
> Hi Borislav,
> 
> I would think that properties in the config for web container is a relic and should be removed.
> There is no web container in the kernel.  Why would it need that configuration at all?
> 
> Thanks for your response
> 
> Dmitry
> 
> 
> On Aug 12, 2011, at 11:44 AM, Kapukaranov, Borislav wrote:
> 
>> Hi,
>> 
>> Confusing indeed :) I would guess it is a direct result of the introduction of the two ConfigAdmins - one for each region, because of the new shell.
>> And instead of transferring the web configuration from the kernel CA in the user's as it's done with the user configuration probably it was easier to just add the web configuration file in ext. 
>> In any case having it deployed with the tomcat plan sounds more consistent to me :)
>> 
>> But note if that's the case then most likely only changing the properties file in repository/ext will result in a true modification of the properties, haven't tried that though.
>> 
>> HTH,
>> Borislav
>> 
>> -----Original Message-----
>> From: virgo-dev-bounces@xxxxxxxxxxx [mailto:virgo-dev-bounces@xxxxxxxxxxx] On Behalf Of Dmitry Sklyut
>> Sent: Friday, August 12, 2011 6:21 PM
>> To: Virgo Project
>> Subject: [virgo-dev] org.eclipse.virgo.web.properties duplicated
>> 
>> Hi,
>> 
>> Is there a reason that org.eclipse.virgo.web.properties is duplicated in config and repository/ext in RC2?
>> 
>> A bit confusing :)
>> 
>> Regards,
>> Dmitry
>> _______________________________________________
>> virgo-dev mailing list
>> virgo-dev@xxxxxxxxxxx
>> https://dev.eclipse.org/mailman/listinfo/virgo-dev
>> _______________________________________________
>> virgo-dev mailing list
>> virgo-dev@xxxxxxxxxxx
>> https://dev.eclipse.org/mailman/listinfo/virgo-dev
> 
> _______________________________________________
> virgo-dev mailing list
> virgo-dev@xxxxxxxxxxx
> https://dev.eclipse.org/mailman/listinfo/virgo-dev
> _______________________________________________
> virgo-dev mailing list
> virgo-dev@xxxxxxxxxxx
> https://dev.eclipse.org/mailman/listinfo/virgo-dev