[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index] [List Home]
Re: [virgo-dev] Re: snaps checked in

Hi,

this time i tried a little harder.
But didn't get past a Tests failed (crashed) in the snaps.test project.
I guess i missed something essential.

In case someone else is trying to migrate snaps i added the updated virgoise.sh.

I'll investigate the problem next week. If someone else could have a closer look, too that would be a great
timesaver i guess...

Thanks,
florian

Attachment: 0001-Added-virgoise.sh-to-snaps-project.patch
Description: Binary data

Attachment: 0002-Changes-done-through-the-virgoise.sh-script.patch
Description: Binary data

Attachment: 0003-API-changes-in-SnapTransformer-review-needed.patch
Description: Binary data

Attachment: 0004-Fixed-teststubs-dependencies.patch
Description: Binary data

Attachment: 0005-Added-web.tomcat-to-dependencies-review-needed.patch
Description: Binary data


On Jul 7, 2010, at 3:43 PM, Glyn Normington wrote:

> Hi Florian
> 
> Thanks very much for spotting that "slice" which slipped through the net! I've fixed that ([1] with an acknowledgement to yourself) and another that showed up via:
> 
> ls -lR | grep slice
> 
> The invitation to get the slices code working on top of Virgo instead of dm Server is still open. :-)
> 
> Glyn
> [1] http://git.eclipse.org/c/virgo/org.eclipse.virgo.snaps.git/commit/?id=b3494fc78bf727f45c55d4e25f8de335918b6490
> On 7 Jul 2010, at 13:05, Florian Waibel wrote:
> 
>> Hi,
>> 
>> i followed your invitation :)
>> 
>> #!/usr/bin/env bash
>> dir=`dirname $0`
>> dir=`cd $dir;pwd`
>> 
>> for f in $(find . -iname "*.java" -or -iname "*.aj" -or -iname "*.xml" -or -iname ".project" -or -iname "*.MF" -or -iname "*.mf" -or -iname ".prefs"  -or -iname ".classpath" -or -iname "build.versions" -or -iname "*.properties" -or -iname "*.bat" -or -iname "*.sh" -or -iname "*.conf" -or -iname "*.profile" -or -iname "*.config" -or -iname "*.plan" -or -iname "runner.bundles")
>> do
>> 	
>> sed -i -e 's/SLICES_IVY_CACHE/SNAPS_IVY_CACHE/g' $f
>> sed -i -e 's/SLICE_/SNAP_/g' $f
>> sed -i -e 's/SLICES_/SNAPS_/g' $f
>> sed -i -e 's/slice\.simple/snap\.simple/g' $f
>> 
>> rm $f-e
>> done
>> 
>> One "missed" refactoring in project test-apps/simple-snap:
>> 
>> #mkdir -p test-apps/simple-snap/src/main/java/snap/simple
>> #mv test-apps/simple-snap/src/main/java/slice/simple/*java test-apps/simple-snap/src/main/java/snap/simple
>> #rmdir test-apps/simple-snap/src/main/slice/simple
>> 
>> I don't know about the $dir/update-dependency.rb commands. So those lines are missing...
>> 
>> Regards,
>> florian
>> 
>> -- 
>> Florian Waibel
>> EclipseSource
>> Email: fwaibel@xxxxxxxxxxxxxxxxx
>> Tel: +49-721-66-47-33-0
>> Fax: +49-721-66-47-33-29
>> http://www.eclipsesource.com/
>> ========================= Legal Disclaimer =================================
>> According to Section 80 of the German Corporation Act
>> Innoopract Informationssysteme GmbH must indicate the following information:
>> Address: Stephanienstrasse 20, 76133 Karlsruhe Germany
>> General Manager: Jochen Krause
>> Registered Office: Commercial Register Mannheim HRB 107883
>> ============================================================================
>> 
>> On Jul 7, 2010, at 9:53 AM, Glyn Normington wrote:
>> 
>>> Oh, I should also have mentioned the slices->snaps migration notes:
>>> 
>>> http://wiki.eclipse.org/Virgo/Community#Migrating_from_the_dm_Server_slices_prototype_to_the_Virgo_snaps_prototype
>>> 
>>> Glyn
>>> On 6 Jul 2010, at 19:02, Glyn Normington wrote:
>>> 
>>>> I've checked in snaps to Eclipse git. See [1] for the location.
>>>> 
>>>> The only changes I've made compared to the slices prototype is to uniformly rename "slices" to "snaps" (including the singular and other capitalisations), to re-package the code to org.eclipse.virgo packages, and to get this building cleanly with Virgo build. It still has dm Server pre-reqs and needs "virgoising" (the virgoise.sh shell script in the web server repo provides a good starting point).
>>>> 
>>>> If anyone would care to provide a patch to get this working with Virgo, please be my guest.
>>>> 
>>>> Glyn
>>>> 
>>>> [1] http://wiki.eclipse.org/Virgo/Source#Virgo_git_Repositories
>>> 
>>> _______________________________________________
>>> virgo-dev mailing list
>>> virgo-dev@xxxxxxxxxxx
>>> https://dev.eclipse.org/mailman/listinfo/virgo-dev
>> 
>