Skip to main content

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index] [List Home]
Re: [ve-dev] [Minor patch] NumberCellEditor.java

Just after sending previous mail I searched for more occurrences and saw that MinmaxValidator.java and NumberLabelProvider.java also uses the Ibm version of NumberFormat, maybe change these also?

Regards.

Kenneth Styrberg skrev:
In NumberCellEditor the parsing for negative integers seem to be borked somehow.

When setting a negative property the parser responds that number is non integer.

I tracked it down to the negative sign that is compared in NumberFormat class. With the "com.ibm.icu.text" version the negative sign is not parsed to same value as in the "java.text" version. A simple switch fixed this problem. This might be a locale problem as more people
should have noticed it?!

Regards.





### Eclipse Workspace Patch 1.0
#P org.eclipse.ve.propertysheet
Index: propertysheet/org/eclipse/ve/internal/propertysheet/NumberCellEditor.java
===================================================================
RCS file: /cvsroot/tools/org.eclipse.ve/plugins/org.eclipse.ve.propertysheet/propertysheet/org/eclipse/ve/internal/propertysheet/NumberCellEditor.java,v
retrieving revision 1.9
diff -u -r1.9 NumberCellEditor.java
--- propertysheet/org/eclipse/ve/internal/propertysheet/NumberCellEditor.java 17 May 2006 20:16:06 -0000 1.9 +++ propertysheet/org/eclipse/ve/internal/propertysheet/NumberCellEditor.java 18 Apr 2009 22:32:19 -0000
@@ -15,6 +15,7 @@
  */


+import java.text.NumberFormat;
 import java.text.ParseException;
 import java.text.ParsePosition;

@@ -22,8 +23,6 @@
 import org.eclipse.core.runtime.IExecutableExtension;
 import org.eclipse.swt.widgets.Composite;

-import com.ibm.icu.text.NumberFormat;
-
 /**
  * Number Celleditor that formats according to the current locale.
  * It can also handle a null by allowing null to come in. It will be
_______________________________________________
ve-dev mailing list
ve-dev@xxxxxxxxxxx
https://dev.eclipse.org/mailman/listinfo/ve-dev



Back to the top