Skip to main content

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index] [List Home]
Re: [ufk-dev] Swing ObservableListTableModel remove glitch

Hi,

Hm - I don't think so but as indicated by the comment in the code the
real solution is to work with ranges if possible, so the visitor is not
helping us there anyways.

Tom

Am 09.02.11 00:14, schrieb Max Gordienko:
> Awesome!
> This is patch really did the trick! Thank you very much, Tom!
> 
> By the way, why fireTableRowsDeleted(1,1) was called? If two first
> elements are removed ListDiff
> will generate two Diff entries with index 0. And ListDiffVisitor will
> pass this 0 twice to the underlying model.
> Isn't it?
> 
> On 9 February 2011 05:09, Tom Schindl <tom.schindl@xxxxxxxxxxxxxxx> wrote:
>> Hi,
>>
>> I've found the problem and fixed it in SVN.
>>
>> The problem is that when a multi remove/add happens we should have
>> delivered e.g. for the remove a fireTableRowsDeleted(0,0) twice but we
>> delivered something like this:
>>
>> fireTableRowsDeleted(0,0)
>> fireTableRowsDeleted(1,1)
>>
>> I'll try to implement a better fix later when I have more time. E.g. we
>> should fireTableRowsDeleted() with a range, same is true for additions
>> instead of single events who force a redraw everytime.
>>
>> Tom
> _______________________________________________
> ufk-dev mailing list
> ufk-dev@xxxxxxxxxxx
> https://dev.eclipse.org/mailman/listinfo/ufk-dev


-- 
B e s t S o l u t i o n . a t                        EDV Systemhaus GmbH
------------------------------------------------------------------------
tom schindl                                        geschaeftsfuehrer/CEO
------------------------------------------------------------------------
eduard-bodem-gasse 5/1    A-6020 innsbruck      phone    ++43 512 935834


Back to the top