Skip to main content

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index] [List Home]
Re: [tycho-user] [cross-project-issues-dev] Using maven artifacts directly in eclipse target platform / tycho builds

If the jar is an OSGi bundle and it is signed it will remain so, if it is a jar and is signed it will be transformed in an OSGi bundle and obviously needs to be resigned. See [1] for an example to sign artifacts in an P2 updatesite after the fact 8regardless of the source.

[1] https://bugs.eclipse.org/bugs/show_bug.cgi?id=570191

Am 21.01.21 um 15:56 schrieb Ed Merks:
I think it matters because in the end, the result is jarred and that jar is not signed:

https://bugs.eclipse.org/bugs/show_bug.cgi?id=570315


On 21.01.2021 15:52, Wim Jongman wrote:
I mean, does it matter if the wrapper is not signed as long as the wrapped jar is signed?

On Thu, Jan 21, 2021 at 3:51 PM Wim Jongman <wim.jongman@xxxxxxxxx <mailto:wim.jongman@xxxxxxxxx>> wrote:

    Does it matter if the underlying jar is signed?

    On Thu, Jan 21, 2021 at 3:44 PM Ed Merks <ed.merks@xxxxxxxxx
    <mailto:ed.merks@xxxxxxxxx>> wrote:

        Note though that there are issues with signing, i.e., these
        synthesized artifacts are *not *signed.

        On 21.01.2021 15:19, Christoph Läubrich wrote:
        You can use the artifacts as you use any other bundle,
        include them in a feature/updatesite/product, no special
        action/treatment required.

        Am 21.01.21 um 15:16 schrieb Wim Jongman:
        Wow, that is a big project. Well done.

        I get that this enables us to easily create a target
        platform that does not rely on Orbit anymore. However, when
        I want to publish my bundles in a P2 repo, how are the mvn
        dependencies included. Do they need to land in Orbit anyway
        at some point? Or should I include them as a fat jar?

        Cheers,

        Wim



        On Tue, Jan 5, 2021 at 1:30 PM Christoph Läubrich
        <laeubi@xxxxxxxxxxxxxx <mailto:laeubi@xxxxxxxxxxxxxx>
        <mailto:laeubi@xxxxxxxxxxxxxx>
        <mailto:laeubi@xxxxxxxxxxxxxx>> wrote:

            P2 has nothing to do with it, even though many users
        using P2 sites
            as a
            source for bundles in the target platform, it could
        contain other
            sources as well (e.g. from local eclipse install,
        directories, ...) and
            this feature simply adds Maven as a source where bundles
        are pulled
            from.

            Of course you can use such a target and create a feature
        that
            references
            a bundles that originates in maven and then included it
        into an
            update-site that is later used to install something via
        P2 but that's
            not mandatory.


            Am 05.01.21 um 13:21 schrieb Ed Merks:
             > I'm kind of confused.  Are you suggesting that p2
        will be able
            install
             > such dependencies if they are not actually in
        published to a p2
            repository?
             >
             >
             > On 05.01.2021 12:41, Christoph Läubrich wrote:
             >> They are only repacked/wrapped if they are not OSGi
        artifacts
            already
             >> and if you request this.
             >>
             >> There is no need to publish them anywhere (as they
        are already
             >> published in maven central) just use them as if they
        where P2
             >> published ones, you should still issue IP requests
        for new
             >> dependencies, there is no guarantee for any
        published P2 site
            either
             >> that it is reviewed for whatever policy.
             >>
             >>
             >>
             >>
             >> Am 05.01.21 um 12:27 schrieb Ed Merks:
             >>> I read the article, but what's not clear to me is
        how the
             >>> magically-created-and-repackaged-as-a-bundle Maven
        artifacts are
             >>> republished.  I assume they must end up in a p2
        repo to be
             >>> installable somewhere...  Of course in terms of
        Eclipse Project
            using
             >>> this cool support, the question then is: how will
        the life cycles
             >>> will work if such things are magically created
        independently by
             >>> different projects on demand and also perhaps more
            significantly, how
             >>> are they IP reviewed if they've been pulled
        straight from some
            Maven
             >>> repository somewhere?
             >>>
             >>> On 05.01.2021 08:48, Mickael Istria wrote:
             >>>>
             >>>> Thanks for all this very powerful and interesting
        work
            Christian! I
             >>>> think it's really a good way forward and a good
        opportunity to
             >>>> progressively replace Orbit by a more "build
        native" approach
            that
             >>>> will make adoption of Maven artifacts by Eclipse
        projects much
             >>>> easier and faster than the current process with
        Orbit.
             >>>>
             >>>> On Tue, Jan 5, 2021 at 7:57 AM Ed Willink
            <ed.willink@xxxxxxxxx <mailto:ed.willink@xxxxxxxxx>
        <mailto:ed.willink@xxxxxxxxx> <mailto:ed.willink@xxxxxxxxx>
             >>>> <mailto:ed.willink@xxxxxxxxx
        <mailto:ed.willink@xxxxxxxxx> <mailto:ed.willink@xxxxxxxxx>
        <mailto:ed.willink@xxxxxxxxx>>>
            wrote:
             >>>>
             >>>>     for my (small number of) users the problem is
        the other
            way round.
             >>>>     How to make Eclipse standalone project
        releases easily
            consumable
             >>>>     by Maven.
             >>>>
             >>>>
             >>>> It's indeed a different problem and requires
        different
            solution. My
             >>>> current impression as I deal more and more with
        things like
            Language
             >>>> Servers and other stuff that are not purely
        Eclipse Platfrom
             >>>> artifacts but then gets consumed in an Eclipse IDE
        is that if
            your
             >>>> project also targets plain Java and non-Eclipse
        Platform
             >>>> deployments, then it's better to just make it a
        plain Java
            project
             >>>> (ie stop using MANIFEST-first and PDE to develop
        it; do plain
            Java,
             >>>> Maven, BND and so on); and then consume those
        artifacts in your
             >>>> Eclipse Platform integration using the strategies
        described by
             >>>> Christian in his blog post.
             >>>> Consuming Maven jars in Eclipse Platform is a much
        better
            (simpler)
             >>>> handled problem than consuming OSGi artifacts in
        plain Java.
             >>>> --
             >>>> Mickael Istria
             >>>> Eclipse IDE
            <https://www.eclipse.org/downloads/eclipse-packages/
        <https://www.eclipse.org/downloads/eclipse-packages/>
        <https://www.eclipse.org/downloads/eclipse-packages/>
        <https://www.eclipse.org/downloads/eclipse-packages/>>
             >>>> developer, for Red Hat Developers
            <https://developers.redhat.com/
        <https://developers.redhat.com/>
        <https://developers.redhat.com/>
        <https://developers.redhat.com/>>
             >>>>
             >>>> _______________________________________________
             >>>> tycho-user mailing list
             >>>> tycho-user@xxxxxxxxxxx
        <mailto:tycho-user@xxxxxxxxxxx>
        <mailto:tycho-user@xxxxxxxxxxx> <mailto:tycho-user@xxxxxxxxxxx>
             >>>> To unsubscribe from this list,
             >>>>
        visithttps://www.eclipse.org/mailman/listinfo/tycho-user
        <http://www.eclipse.org/mailman/listinfo/tycho-user>
        <http://www.eclipse.org/mailman/listinfo/tycho-user>
        <http://www.eclipse.org/mailman/listinfo/tycho-user>
             >>>
             >>> _______________________________________________
             >>> tycho-user mailing list
             >>> tycho-user@xxxxxxxxxxx
        <mailto:tycho-user@xxxxxxxxxxx>
        <mailto:tycho-user@xxxxxxxxxxx> <mailto:tycho-user@xxxxxxxxxxx>
             >>> To unsubscribe from this list, visit
             >>> https://www.eclipse.org/mailman/listinfo/tycho-user
        <https://www.eclipse.org/mailman/listinfo/tycho-user>
        <https://www.eclipse.org/mailman/listinfo/tycho-user>
        <https://www.eclipse.org/mailman/listinfo/tycho-user>
             >>>
             >> _______________________________________________
             >> tycho-user mailing list
             >> tycho-user@xxxxxxxxxxx
        <mailto:tycho-user@xxxxxxxxxxx>
        <mailto:tycho-user@xxxxxxxxxxx> <mailto:tycho-user@xxxxxxxxxxx>
             >> To unsubscribe from this list, visit
             >> https://www.eclipse.org/mailman/listinfo/tycho-user
        <https://www.eclipse.org/mailman/listinfo/tycho-user>
        <https://www.eclipse.org/mailman/listinfo/tycho-user>
        <https://www.eclipse.org/mailman/listinfo/tycho-user>
             > _______________________________________________
             > tycho-user mailing list
             > tycho-user@xxxxxxxxxxx
        <mailto:tycho-user@xxxxxxxxxxx>
        <mailto:tycho-user@xxxxxxxxxxx> <mailto:tycho-user@xxxxxxxxxxx>
             > To unsubscribe from this list, visit
             > https://www.eclipse.org/mailman/listinfo/tycho-user
        <https://www.eclipse.org/mailman/listinfo/tycho-user>
        <https://www.eclipse.org/mailman/listinfo/tycho-user>
        <https://www.eclipse.org/mailman/listinfo/tycho-user>
            _______________________________________________
            tycho-user mailing list
        tycho-user@xxxxxxxxxxx <mailto:tycho-user@xxxxxxxxxxx>
        <mailto:tycho-user@xxxxxxxxxxx> <mailto:tycho-user@xxxxxxxxxxx>
            To unsubscribe from this list, visit
        https://www.eclipse.org/mailman/listinfo/tycho-user
        <https://www.eclipse.org/mailman/listinfo/tycho-user>
        <https://www.eclipse.org/mailman/listinfo/tycho-user>
        <https://www.eclipse.org/mailman/listinfo/tycho-user>


        _______________________________________________
        tycho-user mailing list
        tycho-user@xxxxxxxxxxx <mailto:tycho-user@xxxxxxxxxxx>
        To unsubscribe from this list, visit
        https://www.eclipse.org/mailman/listinfo/tycho-user
        <https://www.eclipse.org/mailman/listinfo/tycho-user>

        _______________________________________________
        tycho-user mailing list
        tycho-user@xxxxxxxxxxx <mailto:tycho-user@xxxxxxxxxxx>
        To unsubscribe from this list, visit
        https://www.eclipse.org/mailman/listinfo/tycho-user
        <https://www.eclipse.org/mailman/listinfo/tycho-user>
        _______________________________________________
        tycho-user mailing list
        tycho-user@xxxxxxxxxxx <mailto:tycho-user@xxxxxxxxxxx>
        To unsubscribe from this list, visit
        https://www.eclipse.org/mailman/listinfo/tycho-user
        <https://www.eclipse.org/mailman/listinfo/tycho-user>


_______________________________________________
tycho-user mailing list
tycho-user@xxxxxxxxxxx
To unsubscribe from this list, visithttps://www.eclipse.org/mailman/listinfo/tycho-user

_______________________________________________
tycho-user mailing list
tycho-user@xxxxxxxxxxx
To unsubscribe from this list, visit https://www.eclipse.org/mailman/listinfo/tycho-user



Back to the top