Re: [tycho-user] Antwort: Warning about thread safety when using Tycho 1

["Sievers, Jan" <jan.sievers@xxxxxxx>]

https://bugs.eclipse.org/bugs/show_bug.cgi?id=380169


On 05.07.18, 10:35, "tycho-user-bounces@xxxxxxxxxxx on behalf of Katrin STRASSL" <tycho-user-bounces@xxxxxxxxxxx on behalf of Katrin.STRASSL@xxxxxxxxxxxxxxxxxxxxxxx> wrote:

    I made a mistake during testing, sorry.Tycho 1.1.0 behaves the same as Tycho 1.2.0 regarding the warnings - with Maven 3.3.9 there is a warning in the debug output, with Maven 3.5.3 the warning is always visible.
    But the question is still the same, is Tycho thread safe?
    Thanks! 
    
    
    
    Von:        "Katrin STRASSL" <Katrin.STRASSL@xxxxxxxxxxxxxxxxxxxxxxx>
    An:        Tycho user list <tycho-user@xxxxxxxxxxx>,
    
    Datum:        05.07.2018 10:24
    Betreff:        [tycho-user] Warning about thread safety when using Tycho 1.2.0 and building with parallel execution
    Gesendet von:        tycho-user-bounces@xxxxxxxxxxx
    
    ________________________________________
    
    
    
    _______________________________________________
    tycho-user mailing list
    tycho-user@xxxxxxxxxxx
    To change your delivery options, retrieve your password, or unsubscribe from this list, visit
    https://dev.eclipse.org/mailman/listinfo/tycho-user
    ----- Nachricht von "Katrin STRASSL" <Katrin.STRASSL@xxxxxxxxxxxxxxxxxxxxxxx> auf Thu, 5 Jul 2018 10:23:53 +0200 -----An:
    Tycho user list <tycho-user@xxxxxxxxxxx> Betreff:
    [tycho-user] Warning about thread safety when using Tycho 1.2.0 and building with parallel execution
    Hi, 
    
    since upgrading to both Tycho 1.2.0 and Eclipse Photon maven prints the following warning during build:
    
    [WARNING] *****************************************************************
    [WARNING] * Your build is requesting parallel execution, but project      *
    [WARNING] * contains the following plugin(s) that have goals not marked   *
    [WARNING] * as @threadSafe to support parallel building.                  *
    [WARNING] * While this /may/ work fine, please look for plugin updates    *
    [WARNING] * and/or request plugins be made thread-safe.                   *
    [WARNING] * If reporting an issue, report it against the plugin in        *
    [WARNING] * question, not against maven-core                              *
    [WARNING] *****************************************************************
    [WARNING] The following goals are not marked @threadSafe in $projectName:
    [WARNING] org.eclipse.tycho:tycho-packaging-plugin:1.2.0:build-qualifier
    [WARNING] org.eclipse.tycho:tycho-packaging-plugin:1.2.0:package-plugin
    [WARNING] org.eclipse.tycho:tycho-p2-plugin:1.2.0:p2-metadata-default
    [WARNING] org.eclipse.tycho:tycho-compiler-plugin:1.2.0:compile
    [WARNING] org.eclipse.tycho:tycho-packaging-plugin:1.2.0:validate-version
    [WARNING] org.eclipse.tycho:tycho-packaging-plugin:1.2.0:validate-id
    [WARNING] org.eclipse.tycho:target-platform-configuration:1.2.0:target-platform
    [WARNING] org.eclipse.tycho:tycho-p2-plugin:1.2.0:update-local-index
    [WARNING] *****************************************************************
    
    The build itself seems to work fine, so it might be a new and unnecessary warning triggered by the newer Maven version in Eclipse Photon.
    
    It (obviously) only appears when selecting more than one thread in the Eclipse Maven Run Configuration or when running from the command line with "-T 1C" switch enabled.
    
                 +----------------+------------------+ 
                 |                |                  | 
                 |  Maven  3.3.9  |   Maven  3.5.3   | 
                 | Eclipse Oxygen | (Eclipse Photon) |
                 |                |                  | 
    +-------------------------------------------------+ 
    |             |                |                  | 
    | Tycho 1.1.0 |   no warning   |    no warning    | 
    |             |                |                  | 
    +-------------------------------------------------+ 
    |             |    warning     |                  | 
    | Tycho 1.2.0 |    only in     | warning  appears | 
    |             |  debug output  |                  | 
    +-------------+----------------+------------------+ 
    
    As you can see in the matrix above, there is no warning at all when using Tycho 1.1.0. Maven 3.3.9 warns about Tycho 1.2.0, but only with debug output enabled. Maven 3.5.3 shows the warning every time (although with different wording with/without debug output).
    
    Is Tycho 1.2.0 thread safe? Can we build parallelized or shouldn't we use that flag?
    
    Thank you![Anhang "smime.p7s" gelöscht von Katrin STRASSL/SPRECHER]