[
Date Prev][
Date Next][
Thread Prev][
Thread Next][
Date Index][
Thread Index]
[
List Home]
|
Re: [tycho-user] Problems changing the compiler to google error-prone
|
My question is, does groovy-eclipse-compiler support classpath
access rules as described in [1]?
[1]
http://help.eclipse.org/kepler/index.jsp?topic=%2Forg.eclipse.jdt.doc.user%2Ftasks%2Ftask-using_batch_compiler.htm&cp=1_3_8_0
--
Regards,
Igor
On 1/9/2014, 11:10, Tonny Madsen wrote:
I have the following in my pom and it seems to work as intended. /Tonny
<build>
<plugins>
<plugin>
<groupId>org.eclipse.tycho</groupId>
<artifactId>tycho-compiler-plugin</artifactId>
<configuration>
<compilerId>groovy-eclipse-compiler</compilerId>
<verbose>true</verbose>
</configuration>
<dependencies>
<dependency>
<groupId>org.codehaus.groovy</groupId>
<artifactId>groovy-eclipse-compiler</artifactId>
<version>2.8.0-01</version>
</dependency>
<!-- The compiler seems to be optional :-/ - so we have to include it
here... -->
<dependency>
<groupId>org.codehaus.groovy</groupId>
<artifactId>groovy-eclipse-batch</artifactId>
<version>[1.8.3-01,9.9.9)</version>
</dependency>
</dependencies>
</plugin>
</plugins>
</build>
--
Tonny Madsen
My profiles: LinkedIn <http://www.linkedin.com/in/tonnymadsen> Twitter
<http://twitter.com/tonnymadsen> Blogger
<http://tonnymadsen.blogspot.dk/> SlideShare
<http://www.slideshare.net/nonty>
On Thu, Jan 9, 2014 at 4:17 PM, Igor Fedorenko <igor@xxxxxxxxxxxxxx
<mailto:igor@xxxxxxxxxxxxxx>> wrote:
Does groovy compiler support classpath visibility rules? I am fine
allowing alternative compilers as long as we don't have to account for
different compiler capabilities in tycho.
On a related note, I am working on a proper incremental compiler
implementation both for "plain" maven and tycho projects. I won't have
this ready for at least couple of months, but this will break
compatibility with plexus compiler API when I push these changes.
--
Regards,
Igor
On 1/9/2014, 10:09, Tonny Madsen wrote:
I have to check but I believe we use the same functionality to
compile
Groovy files... So if you choose to remove this option, then you
must
add something else for Groovy & friends.
/Tonny
--
Tonny Madsen
(sent from my mobile device)
On 9 Jan 2014 13:28, "Igor Fedorenko" <igor@xxxxxxxxxxxxxx
<mailto:igor@xxxxxxxxxxxxxx>
<mailto:igor@xxxxxxxxxxxxxx <mailto:igor@xxxxxxxxxxxxxx>>> wrote:
I would rather remove the option to switch compiler
implementations.
I think it was left there simply because we copied
maven-compiler-plugin base class, but I don't believe it
makes a lot
of sense for Tycho projects.
--
Regards,
Igor
On 1/9/2014, 3:31, Sievers, Jan wrote:
tycho uses the eclipse JDT compiler by default (it has
additional
features like package access rules for exported
packages etc.).
Not sure but I think the idea was that the compiler
implementation
should be interchangeable (and you may lose some additional
features if
not using JDT).
If that is true this would qualify as a bug and we
should make
sure we
only use JDT-specific compiler arguments if the JDT
compiler is
actually
used.
I don't know the error-prone javac extension but JDT
compiler
warnings
or findbugs may provide similar functionality.
Regards,
Jan
*From:*tycho-user-bounces@__ec__lipse.org
<http://eclipse.org>
<mailto:tycho-user-bounces@__eclipse.org
<mailto:tycho-user-bounces@xxxxxxxxxxx>>
[mailto:tycho-user-bounces@
<mailto:tycho-user-bounces@>__e__clipse.org <http://eclipse.org>
<mailto:tycho-user-bounces@__eclipse.org
<mailto:tycho-user-bounces@xxxxxxxxxxx>>] *On Behalf Of
*Christian Schwarz
*Sent:* Mittwoch, 8. Januar 2014 15:38
*To:* Tycho user list
*Subject:* [tycho-user] Problems changing the compiler
to google
error-prone
Hi,
we want to ensure the quality of our code by compiling
it with
google's
javac extension "error-prone" (see
https://code.google.com/p/____error-prone/
<https://code.google.com/p/__error-prone/>
<https://code.google.com/p/__error-prone/
<https://code.google.com/p/error-prone/>>). I don't know what is
going on
here since my experience with maven-tycho is limited. I
get this
error
with tycho v0.19.0:
*[ERROR] Failed to execute goal
org.eclipse.tycho:tycho-____compiler-plugin:0.19.0:compile
(default-compile) on project eu.gemtec.carepi.io
<http://eu.gemtec.carepi.io>
<http://eu.gemtec.carepi.io>
<http://eu.gemtec.carepi.io>: Fatal error compiling:
invalid flag:
org.osgi.framework.system.____packages *
The pom configuration of the tycho compiler look like this:
<plugin>
<groupId>org.eclipse.tycho</____groupId>
<artifactId>tycho-compiler-____plugin</artifactId>
<version>${tycho.version}</____version>
<configuration>
<compilerId>javac-with-____errorprone</compilerId>
</configuration>
<dependencies>
<dependency>
<groupId>org.codehaus.plexus</____groupId>
<artifactId>plexus-compiler-____javac</artifactId>
<version>2.3</version>
</dependency>
<dependency>
<groupId>org.codehaus.plexus</____groupId>
<artifactId>plexus-compiler-____javac-errorprone</artifactId>
<version>2.3</version>
</dependency>
</dependencies>
</plugin>
Does anyone know how to solve it?
Regards
Chris
___________________________________________________
tycho-user mailing list
tycho-user@xxxxxxxxxxx <mailto:tycho-user@xxxxxxxxxxx>
<mailto:tycho-user@xxxxxxxxxxx <mailto:tycho-user@xxxxxxxxxxx>__>
https://dev.eclipse.org/____mailman/listinfo/tycho-user
<https://dev.eclipse.org/__mailman/listinfo/tycho-user>
<https://dev.eclipse.org/__mailman/listinfo/tycho-user
<https://dev.eclipse.org/mailman/listinfo/tycho-user>>
___________________________________________________
tycho-user mailing list
tycho-user@xxxxxxxxxxx <mailto:tycho-user@xxxxxxxxxxx>
<mailto:tycho-user@xxxxxxxxxxx <mailto:tycho-user@xxxxxxxxxxx>__>
https://dev.eclipse.org/____mailman/listinfo/tycho-user
<https://dev.eclipse.org/__mailman/listinfo/tycho-user>
<https://dev.eclipse.org/__mailman/listinfo/tycho-user
<https://dev.eclipse.org/mailman/listinfo/tycho-user>>
_________________________________________________
tycho-user mailing list
tycho-user@xxxxxxxxxxx <mailto:tycho-user@xxxxxxxxxxx>
https://dev.eclipse.org/__mailman/listinfo/tycho-user
<https://dev.eclipse.org/mailman/listinfo/tycho-user>
_________________________________________________
tycho-user mailing list
tycho-user@xxxxxxxxxxx <mailto:tycho-user@xxxxxxxxxxx>
https://dev.eclipse.org/__mailman/listinfo/tycho-user
<https://dev.eclipse.org/mailman/listinfo/tycho-user>
_______________________________________________
tycho-user mailing list
tycho-user@xxxxxxxxxxx
https://dev.eclipse.org/mailman/listinfo/tycho-user
