Re: [tycho-user] jgit timestamp provider ignores local changes

[Igor Fedorenko <igor@xxxxxxxxxxxxxx>]

I would not use SNAPSHOT version qualifier, and now thinking about it,
using conventional .qualifier is not a good idea either. Both come
alphabetically after numbers and will effectively override any git
derived qualifiers.

--
Regards,
Igor

On 2013-03-11 12:40 PM, Max Rydahl Andersen wrote:
> On Mon, Mar 11, 2013 at 05:18:23PM +0100, Mickael Istria wrote:
> > On 03/05/2013 04:51 PM, Igor Fedorenko wrote:
> > > https://git.eclipse.org/c/tycho/org.eclipse.tycho.extras.git/tree/tycho-buildtimestamp-jgit/src/main/java/org/eclipse/tycho/extras/buildtimestamp/jgit/JGitBuildTimestampProvider.java?id=tycho-extras-0.16.0#n82
> > >
> > >
> > >
> > > I'll be willing to review a quality patch... but if somebody with good
> > > jgit knowledge did that it'd be even better.
> >
> > What would you think about the following approach:
> > 1. In case tree is dirty, JBitBuildTimestampProvider returns null
> > 2. In case the timestamp provider returns null, tycho-packaging plugin
> > would use "SNAPSHOT" instead of the timestamp string
> > ?
>
> wouldn't it be better with <jgittimestamp>SNAPSHOT then ?
>
> /max
>
> > --
> > Mickael Istria
> > Eclipse developer at JBoss, by Red Hat <http://www.jboss.org/tools>
> > My blog <http://mickaelistria.wordpress.com> - My Tweets
> > <http://twitter.com/mickaelistria>
>
> > _______________________________________________
> > tycho-user mailing list
> > tycho-user@xxxxxxxxxxx
> > https://dev.eclipse.org/mailman/listinfo/tycho-user
>
> _______________________________________________
> tycho-user mailing list
> tycho-user@xxxxxxxxxxx
> https://dev.eclipse.org/mailman/listinfo/tycho-user