| Re: [tycho-user] jgit timestamp provider ignores local changes |
This will be surprising behaviour (in the bad sense). Proposed behaviour will results in wrong version qualifier produced by CI build if the working tree happens to become dirty for whatever reason, and if you do manual release build. In case of dirty tree jgit timestamp provider should throw an exception "Working tree is dirty, use -DtimestampProvider=default to use current build timestamp. Alternatively, use -DforceContextQualifier=qualifier to use literal '.qualifier' version qualifier". -- Regards, Igor On 2013-03-11 12:18 PM, Mickael Istria wrote:
On 03/05/2013 04:51 PM, Igor Fedorenko wrote:https://git.eclipse.org/c/tycho/org.eclipse.tycho.extras.git/tree/tycho-buildtimestamp-jgit/src/main/java/org/eclipse/tycho/extras/buildtimestamp/jgit/JGitBuildTimestampProvider.java?id=tycho-extras-0.16.0#n82 I'll be willing to review a quality patch... but if somebody with good jgit knowledge did that it'd be even better.What would you think about the following approach: 1. In case tree is dirty, JBitBuildTimestampProvider returns null 2. In case the timestamp provider returns null, tycho-packaging plugin would use "SNAPSHOT" instead of the timestamp string ? -- Mickael Istria Eclipse developer at JBoss, by Red Hat <http://www.jboss.org/tools> My blog <http://mickaelistria.wordpress.com> - My Tweets <http://twitter.com/mickaelistria> _______________________________________________ tycho-user mailing list tycho-user@xxxxxxxxxxx https://dev.eclipse.org/mailman/listinfo/tycho-user