Re: [tycho-user] Concerning "NPE with tycho-buildtimestamp-jgit"

[Igor Fedorenko <igor@xxxxxxxxxxxxxx>]

I merged your change, but unfortunately gerrit is not smart-enougn to
realize that. Can you "abandon" the change in gerrit?

--
Regards,
Igor

On 12-07-30 4:40 AM, Stephan Leicht Vogt wrote:
> Hi
>
> Ok, the ITs fail without the Patch and are running successfully with the patch. In the build log of the it I also see the same NPE as I get with my build. So in my oppinion the patch is fine if running on Windows and no new IT is required.
>
> Greetings
>
> Stephan Leicht Vogt
>
> BSI Business Systems Integration AG
> Täfernstrasse 16a, CH-5405 Baden
> T +41 56 484 19 47
> www.bsiag.com
>
> -----Original Message-----
> From: tycho-user-bounces@xxxxxxxxxxx [mailto:tycho-user-bounces@xxxxxxxxxxx] On Behalf Of Igor Fedorenko
> Sent: Freitag, 27. Juli 2012 23:24
> To: tycho-user@xxxxxxxxxxx
> Subject: Re: [tycho-user] Concerning "NPE with tycho-buildtimestamp-jgit"
>
> These are standard maven-invoker tests. Only special part about them is
> that test projects are in zip files, this is the only way I know to
> include one git repository in another. Maven inoker unzipps the test
> projects, runs "mvn clean install", then executes test's verify.bsh to
> see if all expected files are in place.
>
> If you can run the ITs on windows without your patch, this means new IT
> is required. If tests fail on windows without your patch but pass with
> your patch, then all is good and not new IT is needed.
>
> --
> Regards,
> Igor
>
> On 12-07-27 3:53 PM, Stephan Leicht Vogt wrote:
> > Ok, I ran the test on tycho-buildtimestamp-jgit and they passed. I looked through the files of this it test but unfortunatly I didn't relay understand what it makes.
> > I would gladly understand them, so if there is something to read to it then please point me to it, thanks :-)
> >
> > Greetings
> > Stephan
> >
> > -----Original Message-----
> > From: tycho-user-bounces@xxxxxxxxxxx [mailto:tycho-user-bounces@xxxxxxxxxxx] On Behalf Of Igor Fedorenko
> > Sent: Freitag, 27. Juli 2012 17:28
> > To: tycho-user@xxxxxxxxxxx
> > Subject: Re: [tycho-user] Concerning "NPE with tycho-buildtimestamp-jgit"
> >
> > mvn clean install -Pits
> >
> > I am not sure if wiki says how to run tycho-extras ITs.
> >
> > --
> > Regards,
> > Igor
> >
> > On 12-07-27 11:24 AM, Stephan Leicht Vogt wrote:
> > > Hi Igor
> > >
> > > Now that you mention the integration tests I know why the normal maven tests said "Tests run: 0, Failures: 0, Errors: 0, Skipped: 0". I'll run the integration tests as described in the wiki and look if I can write a test covering this problem.
> > >
> > > Yes, the change id is indeed nice :-)
> > >
> > > Greetings
> > > Stephan
> > >
> > > -----Original Message-----
> > > From: tycho-user-bounces@xxxxxxxxxxx
> > > [mailto:tycho-user-bounces@xxxxxxxxxxx] On Behalf Of Igor Fedorenko
> > > Sent: Freitag, 27. Juli 2012 17:20
> > > To: Tycho user list
> > > Subject: Re: [tycho-user] Concerning "NPE with tycho-buildtimestamp-jgit"
> > >
> > > Do exitsing integration tests cover this problem if run on Windows? If not, we need a test for this.
> > >
> > > Nice gerrit change id, btw :-)
> > >
> > > --
> > > Regards,
> > > Igor
> > >
> > > On 12-07-27 10:11 AM, Stephan Leicht Vogt wrote:
> > > > Hi
> > > >
> > > > I had the same problem and after your discussion I debuged this plugin.
> > > > I found the bug/fix and opend a bugzilla [1] and a patch proposal on
> > > > gerrit [2].
> > > >
> > > > Greetings
> > > > Stephan
> > > >
> > > > [1]: https://bugs.eclipse.org/bugs/show_bug.cgi?id=386133
> > > >
> > > > [2]: https://git.eclipse.org/r/7000
> > > >
> > > > Stephan Leicht Vogt
> > > >
> > > > *BSI**Business Systems Integration AG* Täfernstrasse 16a, CH-5405
> > > > Baden
> > > > *T* +41 56 484 19 47
> > > > www.bsiag.com <http://www.bsiag.com>
> > > >
> > > >
> > > >
> > > > _______________________________________________
> > > > tycho-user mailing list
> > > > tycho-user@xxxxxxxxxxx
> > > > https://dev.eclipse.org/mailman/listinfo/tycho-user
> > > _______________________________________________
> > > tycho-user mailing list
> > > tycho-user@xxxxxxxxxxx
> > > https://dev.eclipse.org/mailman/listinfo/tycho-user
> > >
> > >
> > >
> > > _______________________________________________
> > > tycho-user mailing list
> > > tycho-user@xxxxxxxxxxx
> > > https://dev.eclipse.org/mailman/listinfo/tycho-user
> > _______________________________________________
> > tycho-user mailing list
> > tycho-user@xxxxxxxxxxx
> > https://dev.eclipse.org/mailman/listinfo/tycho-user
> >
> >
> >
> > _______________________________________________
> > tycho-user mailing list
> > tycho-user@xxxxxxxxxxx
> > https://dev.eclipse.org/mailman/listinfo/tycho-user
> _______________________________________________
> tycho-user mailing list
> tycho-user@xxxxxxxxxxx
> https://dev.eclipse.org/mailman/listinfo/tycho-user
>
>
>
> _______________________________________________
> tycho-user mailing list
> tycho-user@xxxxxxxxxxx
> https://dev.eclipse.org/mailman/listinfo/tycho-user