[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index] [List Home]
Re: [tycho-user] tycho-source-feature-plugin - no source generated

My bad, we had a typo in the category.xml :(
We now have a generated , properly-named source feature published in our repo. The only problems I see now are:
  1. it's missing a "label" attribute so shows up as "[project].source.feature.feature.group" - pretty nasty for our consumers.
  2. it's missing a "plugin" attribute identifying the branding plugin so it's not grouped with the rest of our plugins in the Help > About dialog. Certainly less but still important to us.
Thanks for all your help so far and what do you think about these last two issues?

Craig

On Wed, May 2, 2012 at 1:35 PM, Craig Foote <craigfoote@xxxxxxxxx> wrote:
Oh yeah, I forgot to add that the generated source feature is not being added to the built site. I tried duplicating the existing feature in the category.xml and appending -sources-feature but it had no effect. How can we add the generated source feature to our site?

Craig


On Wed, May 2, 2012 at 1:27 PM, Craig Foote <craigfoote@xxxxxxxxx> wrote:
Hi again Mickael,

When you said "files such as feature,properties if" did you mean "features.properties" or "feature.xml. build.properties"? Though we're getting farther, the source feature generated still has problems.

The generated source feature is named "[project.artifactId]-sources-feature", no timestamp. Can we change this to [project.artifactId].sdk_[version_with_timestamp]? I read https://issues.sonatype.org/browse/TYCHO-192 but this seems to be ignored:
   <configuration>
      <sourceBundleSuffix>.sdk_${project.version)</sourceBundleSuffix>
   </configuration>

Also the feature.xml is missing "provider-name" and "label" attributes which I would have expected to be copied over from the binary feature. It also would be nice to have a reference to the branding plugin though that may be affected by it not having any actual source and us having to specify it in the excludes block in the pom.

What do you think?
Craig


On Wed, May 2, 2012 at 12:01 PM, Craig Foote <craigfoote@xxxxxxxxx> wrote:
Great, thanks again.

On Wed, May 2, 2012 at 9:58 AM, Mickael Istria <mistria@xxxxxxxxxx> wrote:
On 05/02/2012 03:17 PM, Craig Foote wrote:
OK, thanks again Mickael. So your comment at https://bugs.eclipse.org/bugs/show_bug.cgi?id=345234#c27 about a patch to make that optional hasn't been applied yet? Are there plans to do so or maybe a bug entered for that?
No, this patch was not applied. I'm now Ok with having to create a folder, but a more explicit message and documentation on it could be helpful.


Is it just an empty folder named "sourceTemplateFeature" at the root of the feature that's required?
Yes, but it is also meant to include there files such as feature,properties if you want to add content to the generated source feature.


--
Mickael Istria
Eclipse developer at JBoss, by Red Hat
My blog - My Tweets

_______________________________________________
tycho-user mailing list
tycho-user@xxxxxxxxxxx
https://dev.eclipse.org/mailman/listinfo/tycho-user