[
Date Prev][
Date Next][
Thread Prev][
Thread Next][
Date Index][
Thread Index]
[
List Home]
|
Re: [tycho-user] How can I help to fix a bug?
|
Hi Lars,
I didn't test running my patch without a product file, but after
taking a look at my code I'm quite sure that it works with any number
(including none) of product files. I will talk briefly about our ant
based workaround in my talk "Release Engineering with tycho and p2" at
our Berlin DemoCamp and we use a regex instead of a XSLT to update the
product version ;-)
Cheers,
Matthias
On Mon, Nov 21, 2011 at 3:41 PM, Lars Martin <lars.martin@xxxxxxxxx> wrote:
>
> Hi Matthias,
>
> I didn't test your patch yet but had a look at the sources. It seems that your patch relies on at least one .product definition per "eclipse-repository" artifact. But AFAIK a product definition isn't mandatory for an artifact of packaging type "eclipse-repository".
>
> Regards, Lars
>
> ----- Original Message -----
>> Hi all,
>>
>> I filed https://bugs.eclipse.org/bugs/show_bug.cgi?id=358292
>> (tycho-versions-plugin doesn't update product for eclipse-repository
>> packaging) at the end of september and added a patch at the end of
>> october. And I saw that other tycho users propose different
>> workarounds for this problem (like using xslt to patch the product
>> version).
>> Since this was the first time I contributed a patch to an eclipse
>> project, I'm unsure if I need some IP clearance before you're able to
>> accept the patch. For us this bug is really nasty and our current ant
>> build.xml workaround puts more complexity into our already quite
>> complex product build. Of course we can also use our own patched
>> version of tycho, but since other tycho users seem to have the same
>> problem it would really be nice to have it in the next stable release
>> of tycho so that others can benefit too.
>> So my question is if I can somehow help you in accepting my patch?
>>
>> Cheers,
>> Matthias
>> _______________________________________________
>> tycho-user mailing list
>> tycho-user@xxxxxxxxxxx
>> https://dev.eclipse.org/mailman/listinfo/tycho-user
>>
> _______________________________________________
> tycho-user mailing list
> tycho-user@xxxxxxxxxxx
> https://dev.eclipse.org/mailman/listinfo/tycho-user
>
