Skip to main content

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index] [List Home]
Re: [tycho-user] Error - 7 icon(s) not replaced in ... using ...

Thanks for the tip about using maven-resources-plugin instead, but I
cannot make it work. I have the icons folder in the root of my folder:

myproduct
 | --> icons
          | --> app.ico
 | -- > myproduct.product
 | -- > pom.xml

In the pom I have:

			<plugin>
				<artifactId>maven-resources-plugin</artifactId>
				<executions>
					<execution>
						<id>copy-resources</id>
						<!-- here the phase you need -->
						<phase>validate</phase>
						<goals>
							<goal>copy-resources</goal>
						</goals>
						<configuration>
							<outputDirectory>${project.build.directory}/products/${project.groupId}.${project.artifactId}</outputDirectory>
							<resources>
								<resource>
									<directory>icons</directory>
								</resource>
							</resources>
						</configuration>
					</execution>
				</executions>
			</plugin>


I have also tried with:


								<resource>
									<directory>${basedir}/icons</directory>
								</resource>


but the content (or the icons folder) never gets copied to the target
path specified in the outputDirectory tag. I have read the
documentation here:

http://maven.apache.org/plugins/maven-resources-plugin/examples/copy-resources.html

but its more or less what you suggest. It will work if I specify
relative paths in the .product file like:

   <launcher name="myApp">
      <solaris/>
      <win useIco="true">
         <ico path="../../../icons/app.ico"/>
         <bmp/>
      </win>
   </launcher>

But as a consequence it will not work with PDE build.





On Tue, Jun 14, 2011 at 1:40 PM, Davy Meers <davymeers@xxxxxxxxxxx> wrote:
> Hello,
> Thank you for your solution.
> I got it working by looking
> at https://github.com/jsievers/tycho-demo/blob/master/tychodemo.product/tychodemo.product (<ico
> path="../../../icons/alt_launcher.ico"/>), unfortunately then the launcher
> icon would not be replaced when exporting with PDE.
> Copying the folder during the build is IMHO a better approach, but i prefer
> not to use ant when it isn't needed.
> In the end I used the maven resources plugin:
> <plugin>
> <artifactId>maven-resources-plugin</artifactId>
> <version>2.5</version>
> <executions>
> <execution>
> <id>copy-resources</id>
> <!-- here the phase you need -->
> <phase>validate</phase>
> <goals>
> <goal>copy-resources</goal>
> </goals>
> <configuration>
> <outputDirectory>${project.build.directory}/products/${project.groupId}.${project.artifactId}</outputDirectory>
> <resources>
> <resource>
> <directory>icons</directory>
> </resource>
> </resources>
> </configuration>
> </execution>
> </executions>
> </plugin>
>
>> Date: Tue, 14 Jun 2011 09:39:06 +0200
>> From: mort.motes@xxxxxxxxx
>> To: tycho-user@xxxxxxxxxxx
>> Subject: Re: [tycho-user] Error - 7 icon(s) not replaced in ... using ...
>>
>> Try to look at this post:
>>
>>
>> http://software.2206966.n2.nabble.com/How-to-apply-patch-no-launcher-icon-TYCHO-300-td6059641.html
>>
>> I have setup an antrun task to copy the icons to the correct
>> destination during the compile phase:
>>
>>
>> <build>
>> <plugins>
>> <plugin>
>> <artifactId>maven-antrun-plugin</artifactId>
>> <!-- Setting up multiple executions. See
>> http://jira.codehaus.org/browse/MANTRUN-86.
>> Sucks!! -->
>> <executions>
>> <execution>
>> <!-- Currently tycho does not understand launcher icon specification
>> the same way as PDE so a manual copy is necessary -->
>> <id>p2.copy.icons</id>
>> <phase>compile</phase>
>> <goals>
>> <goal>run</goal>
>> </goals>
>> <configuration>
>> <target name="p2.copy.icons: ${p2.copy.icons}" if="${p2.copy.icons}">
>> <copy
>>
>> todir="${project.build.directory}/products/${project.groupId}.${project.artifactId}"
>> failonerror="true" file="application.ico" />
>> </target>
>> </configuration>
>> </execution>
>> </executions>
>> <dependencies>
>> <dependency>
>> <groupId>org.apache.ant</groupId>
>> <artifactId>ant-jsch</artifactId>
>> <version>${ant.jsch.version}</version>
>> </dependency>
>> </dependencies>
>> </plugin>
>> ...
>>
>>
>>
>>
>>
>> On Fri, Jun 10, 2011 at 5:22 PM, Davy Meers <davymeers@xxxxxxxxxxx> wrote:
>> > Hello Sandro,
>> > thank you for your fast response.
>> > I tried removing the first "/", it didn't work for me.
>> > I still get the same error. (i also checked the exported product).
>> > I will look further into this on tuesday by creating a small sample
>> > project
>> > and to some testing.
>> > Cheers,
>> > Davy
>> >
>> > ________________________________
>> > From: sandro@xxxxxxx
>> > Date: Fri, 10 Jun 2011 16:37:45 +0200
>> > To: tycho-user@xxxxxxxxxxx
>> > Subject: Re: [tycho-user] Error - 7 icon(s) not replaced in ... using
>> > ...
>> >
>> > Hallo Meers,
>> >
>> > I don't think it's fixed yet. I've found a workaround for this by
>> > removing
>> > the first "/" in the product definition (path to the .icon/.bmp files).
>> > To
>> > be more specific:
>> >
>> > First my icon was defined like this "/com.myapp.branding/myicon.ico".
>> > I replaced it with "com.myapp.branding/myicon.ico".
>> >
>> > This results in an warning in eclipse but produces the correct product
>> > when
>> > building with tycho.
>> >
>> > I hope that helps!
>> >
>> > Cheers,
>> >
>> > Sandro
>> >
>> > On Fri, Jun 10, 2011 at 16:32, Davy Meers <davymeers@xxxxxxxxxxx> wrote:
>> >
>> > Hello,
>> > I am having a problem when exporting a product from a project with
>> > "eclipse-repository" packaging:
>> > the tycho-p2-publisher-plugin:publish-products goal produces the error
>> > "Error - 7 icon(s) not replaced in ... using ...".
>> > This problem is probably related
>> > to https://issues.sonatype.org/browse/TYCHO-300.
>> > Is this problem going to be fixed? Is there a work-around?  (Since
>> > branding
>> > is important for us right know we cannot use tycho to export our
>> > product)
>> > Kind regards,
>> > Meers Davy
>> >
>> >
>> >
>> > _______________________________________________
>> > tycho-user mailing list
>> > tycho-user@xxxxxxxxxxx
>> > https://dev.eclipse.org/mailman/listinfo/tycho-user
>> >
>> >
>> >
>> > _______________________________________________ tycho-user mailing list
>> > tycho-user@xxxxxxxxxxx
>> > https://dev.eclipse.org/mailman/listinfo/tycho-user
>> > _______________________________________________
>> > tycho-user mailing list
>> > tycho-user@xxxxxxxxxxx
>> > https://dev.eclipse.org/mailman/listinfo/tycho-user
>> >
>> >
>> _______________________________________________
>> tycho-user mailing list
>> tycho-user@xxxxxxxxxxx
>> https://dev.eclipse.org/mailman/listinfo/tycho-user
>
> _______________________________________________
> tycho-user mailing list
> tycho-user@xxxxxxxxxxx
> https://dev.eclipse.org/mailman/listinfo/tycho-user
>
>


Back to the top