Skip to main content
[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index] [List Home]
Re: [tycho-dev] tycho vs tycho-extras: what's the value?
  • From: "Sievers, Jan" <jan.sievers@xxxxxxx>
  • Date: Mon, 28 Oct 2019 13:41:31 +0000
  • Accept-language: en-US
  • Arc-authentication-results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=sap.com; dmarc=pass action=none header.from=sap.com; dkim=pass header.d=sap.com; arc=none
  • Arc-message-signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=10/tuv48xnZ6VFfnewfp92bIC7XooYF/pBblf/6sHnE=; b=bznhROFZ+BnWkm/YM9w6egqwRvui7mnXpULvUYmW0N/PyxnU7Wzr8Zmdw8pt5hIgbqYuLTrpe3vVHu7QQ3Ab8E3xvni+nKFnFNrcqQTu+3Poz9gQpWUEhp30r9ALHLgSK/dVxMT4oUukeluEcP612CZlztftlaKDmKFeCFtQj5CvmcnoMmJCTdgksDDkKQPqaWMcMYxH16OOYzZ/K7YlhJUfLQDT32U950UXy0RtjcfnmG/1YBo+GEaJcjaX2ngBBfk0vGPqNv0itXvPPGZg94kY2T+ktRm1FqHCQkFvRzMdMnomxvZ8qp9f5SxrTvfcrvxw2LN+beh+AOetfShFMw==
  • Arc-seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=GXeYKydQ2dykh3jiJFzPk4iLeh3bit1KG/NsiTTsuq0hHaBcl03q39oqePA1ohAaXRkZ97RAFPkc9cp5GlFBfcZiXe9I8i8Pq7Bvjxr4zQ9YcFw60/MALkaB0qZ+5Wxd6qWQSOKLAjQuoe3nohhK7coru9/SRyUVyf4/h4x8E0qIYtib5IlEQBpIdkLvtrCNEpog/4fvJzLnXJJuXNw0SfUCQyCUWrtOMp9MIP3h77X49ZfC9mK4xnPYhvODP5Ypd1QD0clQxsjDZqcjlb2WHQlYK/325NQbp1To06ZpQl4avP6QUlABk7jfMqXu177bOcuBOajVH9E+9JmukMzGDA==
  • Delivered-to: tycho-dev@xxxxxxxxxxx
  • List-archive: <https://www.eclipse.org/mailman/private/tycho-dev>
  • List-help: <mailto:tycho-dev-request@eclipse.org?subject=help>
  • List-subscribe: <https://www.eclipse.org/mailman/listinfo/tycho-dev>, <mailto:tycho-dev-request@eclipse.org?subject=subscribe>
  • List-unsubscribe: <https://www.eclipse.org/mailman/options/tycho-dev>, <mailto:tycho-dev-request@eclipse.org?subject=unsubscribe>
  • Thread-index: AQHVim2y1LLzl43JrESQWq/oISCLSadp470AgAADYICAABcegIABDpkAgAUZ+4A=
  • Thread-topic: [tycho-dev] tycho vs tycho-extras: what's the value?
  • User-agent: Microsoft-MacOutlook/10.1e.0.191013

+1 for merging the two into one repo, the plan sound reasonable

 

I don't know why they were created separate (this dates from before I was committer) and de facto they are tightly coupled and have always been released together.

I think the name tycho-extras is more like a hint that these are optional add-ons that not every tycho build necessarily needs.

 

technically I would keep things the same on maven artifactId/groupId level and simply combine the two builds into on with a common parent.

As you already said this would probably  get rid of some double-maintenance of version management of dependencies and other top-level pom settings.

So in effect building/releasing Tycho is simplified but for the user things stay the same.

 

Regards

Jan

 

 

 

From: "mistria@xxxxxxxxxx" <mistria@xxxxxxxxxx>
Date: Friday, 25. October 2019 at 10:48
To: Tycho list <tycho-dev@xxxxxxxxxxx>, Jan Sievers <jan.sievers@xxxxxxx>
Subject: Re: [tycho-dev] tycho vs tycho-extras: what's the value?

 

So here is my proposal of execution

Phase 1

1. we move all the content of org.eclipse.tycho.extras into a top-level "tycho-extras" folder in the same repo

2. From org.eclipse.tycho (non-extras) Git repo, we fetch the top of tycho.extras and merge it

  -> This should result in a merge commit with 2 branches of history: one about tycho-core and the other about tycho-extras, so history is still there

  -> the tycho-extras folder is not part of tycho-core

3. we tweak the existing core CI jobs to build tycho and then build tycho-extras (like it's already done in https://ci.eclipse.org/tycho/job/tycho-build-with-maven-snapshots/ , and we disable tycho-extras builds

 

We wait for some time for some issues to be popping up and remediate them, and when we are happy with it

 

Phase 2

1. we refactor the pom: tycho root pom.xml references tycho-extras, the tycho-extras pom takes the root pom.xml as parent

2. we adapt jobs so the build of tycho & tycho-extras become only 1 step

 

And then, we'll be all set and we can improve things further continuously.

 

Any objection?

@Sievers, Jan specifically, as project lead, do you support this?

Back to the top