[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index] [List Home]
Re: [tycho-dev] Compile error in ExpandedProduct when moving to recent p2

The change is in, so Tycho master now works against p2 master.

 

Regards

Tobias

 

From: tycho-dev-bounces@xxxxxxxxxxx [mailto:tycho-dev-bounces@xxxxxxxxxxx] On Behalf Of Oberlies, Tobias
Sent: Freitag, 6. März 2015 17:48
To: Tycho developers list
Subject: Re: [tycho-dev] Compile error in ExpandedProduct when moving to recent p2

 

My bad. I confused I-builds and N-builds.

 

So I guess that me still needing to write some tests is the only reason why we don’t have this patch submitted yet ;-)

I should be able to get this done on Monday.

 

Regards

Tobias

 

 

From: tycho-dev-bounces@xxxxxxxxxxx [mailto:tycho-dev-bounces@xxxxxxxxxxx] On Behalf Of David M Williams
Sent: Donnerstag, 5. März 2015 16:03
To: Tycho developers list
Subject: Re: [tycho-dev] Compile error in ExpandedProduct when moving to recent p2

 

> This wouldn't be an issue if the Eclipse platform retained I-builds until the next milestone build, but unfortunately they don't.

This is not true. Or, if you've found this, then a mistake was made somewhere. Can you give details, or open a bug? It is certainly our intent to keep them around until the next milestone. Please explain.





From:        "Oberlies, Tobias" <tobias.oberlies@xxxxxxx>
To:        Tycho developers list <tycho-dev@xxxxxxxxxxx>,
Date:        03/05/2015 08:04 AM
Subject:        Re: [tycho-dev] Compile error in ExpandedProduct when moving to recent        p2
Sent by:        tycho-dev-bounces@xxxxxxxxxxx





Hi Pascal,

I've already done the change that adapts Tycho to the p2 changes:
https://git.eclipse.org/r/#/c/41895/
In fact, being able to do that change was the reason why I submitted the changes in p2.

Before submitting the change, I still need to add some unit tests to it. Also, I didn't want to submit it too long before M6 so that we don't have to update Tycho's target definition file all the time.

Best regards
Tobias


> -----Original Message-----
> From: tycho-dev-bounces@xxxxxxxxxxx [
mailto:tycho-dev-
> bounces@xxxxxxxxxxx] On Behalf Of Pascal Rapicault
> Sent: Dienstag, 3. März 2015 15:49
> To: Tycho developers list
> Subject: [tycho-dev] Compile error in ExpandedProduct when moving to
> recent p2
>
> When I build Tycho against p2 from master, I get compile errors because
> the class ExpandedProduct is missing some methods. These errors occur
> because the IProductDescriptor class in p2 has been modified
> (
http://git.eclipse.org/c/equinox/rt.equinox.p2.git/commit/?id=c3cdccddfd
> 6fb7b164b216b605252b718004f6c3).
>
> Though these errors are not new , I'm wondering what are the plans to
> address those and if a patch is needed (which I can provide).
>
> Pascal
> _______________________________________________
> tycho-dev mailing list
> tycho-dev@xxxxxxxxxxx
> To change your delivery options, retrieve your password, or unsubscribe
> from this list, visit
>
https://dev.eclipse.org/mailman/listinfo/tycho-dev
_______________________________________________
tycho-dev mailing list
tycho-dev@xxxxxxxxxxx
To change your delivery options, retrieve your password, or unsubscribe from this list, visit
https://dev.eclipse.org/mailman/listinfo/tycho-dev