Skip to main content

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index] [List Home]
Re: [tycho-dev] gerrit voter and ITs

Are ITs run reliably on hudson? I think intermediate "it compiled" email
does not add much value and will be confusing if there are (real) IT
failures.

--
Regards,
Igor

On 2/5/2014, 7:23, Sievers, Jan wrote:
Hi,

up to now our gerrit voter job

https://hudson.eclipse.org/tycho/job/tycho-gerrit/

verified that for each gerrit proposal, we have a successful build
(including unit tests), but did not execute (long-running) ITs.

The problem here is we want both fast feedback (<5 min) whether the
build succeeded and the added value of automatically verifying ITs
are successful (ITs typically take 20-30 minutes to execute).

I changed the gerrit voter job now to

1. run the build 2. notify gerrit if build successful (this will
trigger a mail like the one below) 3. run ITs

Only if ITs are successful, a +1 verdict is sent to gerrit. (of
course, a -1 verdict is also sent in case step 1 fails)

A test gerrit patchset is here https://git.eclipse.org/r/#/c/20486/

If you think this is a good approach, I would try to do the same
thing for tycho-extras.

Regards, Jan


--- sample gerrit mail ---

Hudson CI has posted comments on this change.

Change subject: test
......................................................................



Patch Set 3:

Build SUCCESSFUL. Now starting integration tests...



Back to the top