Re: [tycho-dev] Change in tycho/org.eclipse.tycho.extras[master]: 425021

["Sievers, Jan" <jan.sievers@xxxxxxx>]

>The issue regarding the output of the files is another discussion I think. Actually you are right, this might cause a dirty state unless these generated files are in 
>.gitignore, same a the whole target/ directory. On the other side the files are required for the build process to be "inside" the bundle. 
> So if you want to use the 
>Eclipse IDE for editing other toc files, or testing this, these files need to be there.

Either the files are generated, then you must not edit them and they should end up in target/.
I don't think it's a god idea to have them "generated but then you can edit them" (unless this is some kind of templating/scaffolding mechanism).

Or if they should be editable, then they must not be generated and should be in the project root.

Just in case, check [1] on how we solved the same problem for the packaging plugin.

>That is why I made the output directory configurable. The default however does not point to a target/ based output directory. But if it would, the setup of the mojo 
>would be more complex, and I tried to reduce that.

My personal take is that defaulting to target/ is what I would expect from a maven point of view.

Best Regards,
Jan


[1] http://eclipse.org/tycho/sitedocs/tycho-packaging-plugin/package-plugin-mojo.html#additionalFileSets 

-----Original Message-----
From: Jens Reimann (Code Review) [mailto:gerrit@xxxxxxxxxxx] 
Sent: Dienstag, 28. Januar 2014 10:56
Cc: Sievers, Jan
Subject: Change in tycho/org.eclipse.tycho.extras[master]: 425021 initial import of doc bundle mojo

Jens Reimann has posted comments on this change.

Change subject: 425021 initial import of doc bundle mojo
......................................................................


Patch Set 5:

Sorry for the delay. I needed to setup up some windows dev environment first. I am testing this right now, since it works for me in Linux. Not sure what it is.

The issue regarding the output of the files is another discussion I think. Actually you are right, this might cause a dirty state unless these generated files are in .gitignore, same a the whole target/ directory. On the other side the files are required for the build process to be "inside" the bundle. So if you want to use the Eclipse IDE for editing other toc files, or testing this, these files need to be there.

That is why I made the output directory configurable. The default however does not point to a target/ based output directory. But if it would, the setup of the mojo would be more complex, and I tried to reduce that.

Maybe we should direct that discussion on the mailing list. Maybe someone else has some good ideas on how to solve this.

-- 
To view, visit https://git.eclipse.org/r/20344
To unsubscribe, visit https://git.eclipse.org/r/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Ifb6ed3596ef1118073ed0cc6caa945fd438071be
Gerrit-PatchSet: 5
Gerrit-Project: tycho/org.eclipse.tycho.extras
Gerrit-Branch: master
Gerrit-Owner: Jens Reimann <jens.reimann@xxxxxxxxxxxxxxx>
Gerrit-Reviewer: Hudson CI
Gerrit-Reviewer: Jan Sievers <jan.sievers@xxxxxxx>
Gerrit-Reviewer: Jens Reimann <jens.reimann@xxxxxxxxxxxxxxx>
Gerrit-HasComments: No