Hi guys,
I'm follwoing discussion from:
https://bugs.eclipse.org/bugs/show_bug.cgi?id=374349#c37 and
https://bugs.eclipse.org/bugs/show_bug.cgi?id=374349#c38
I do know that integrating external contributions, may them require a CQ
or not, is additional work. With a Git-based process in an open
community, being a committer is not only about writing code, it's also
about reviewing contributions, encouraging contributions, leading some
technical discussions... So I'm a bit surprised to hear about committers
complaining getting external contributions into project is extra work:
yes it is, it will always be, and it is part of a committer duty IMO.
To come back more specifically to this contribution, it adds the usage
of Groovy. After a technical discussion, I did all I can to show you
that moving from BeanShell to Groovy is not a bad thing, and that it is
straightforward and adds some cool abilities for testing. As requested,
I wrote all the necessary stuff to merge it. In previous mails and
Gerrit comments, we agreed it would be fine to be integrated, depending
on IP cleanness.
Later, I found out this would require a CQ. Actually, it's not usage of
Groovy by itself, but usage of maven-invoker-plugin that requires it.
Please note that Tycho has been using maven-invoker-plugin for a long
time without any related CQ. So the CQ I suggest is more than an
optional CQ for an optional improvement, it's also a fix in the IP
cleanness of the project.
Then I discussed with Wayne in order to get this CQ as ready as possible
to be submitted. The remaining work for you is simply to click on
https://dev.eclipse.org/ipzilla/show_bug.cgi?id=5252 , adjust by
changing the list of dependencies to the one given earlier. It'd require
less time to submit this CQ than it will require to answer this mail.
About this specific issue (source feature titles and included move to
Groovy), I'm a bit frustrated to see how slow is the integration
process. That's now 2 releases of Tycho since I submitted initial patch.
I got feedback late after the contribution, and it did never get a
chance to get in a release, despite all efforts I made to satisfy
various requirements. Resolution is now blocked by a CQ to be submitted,
and I'm frustrated to see that this issue, which is one of the
top-voted/followed, has simply stagnated for months.
I can fully understand you don't have time to work on this specifically,
or whatever reason that makes it less interesting to you than it is to
all people following the bug. That's totally fair, and that's why I made
as many steps as I can to make it easy for you to get it merged.
So OK, I'm requesting you some extra-work, but I did all I can to
request as little time as possible. I've been doing my best, but it's
not enough. The rest is in your hands, it's work for you. It's how
integrating contributions works.
Cheers,
PS: Note that this comment only applies to this specific case. I'm still
quite happy of how issues are managed in general, and I think you're
doing a good job for both users and contributors. It's just this
source-feature name/Groovy contribution that is bugging me.
On 11/07/2012 11:29 AM, Mickael Istria wrote:
Cool,
Can someone from the Tycho committer team request this CQ to move
forward on using Groovy rather than BeanShell in integration tests?
On 11/06/2012 05:43 PM, Wayne Beaton wrote:
Yes.
Wayne
On 11/06/2012 11:25 AM, Mickael Istria wrote:
On 11/06/2012 04:53 PM, Wayne Beaton wrote:
Hi Mickael.
Since the groovy scripts are included in the source code and are
therefore being distributed, we need to track them.
In this case, a "Build and Test Dependency" is required.
http://wiki.eclipse.org/Development_Resources/IP/Test_and_Build_Dependencies
So if I understand correctly, we need to create a WorksWith CQ
asking for maven-invoker-plugin and its dependencies, that means
maven-invoker-plugin 1.0 +
[INFO] antlr:antlr:jar:2.7.7:compile
[INFO] asm:asm:jar:3.2:compile
[INFO] asm:asm-analysis:jar:3.2:compile
[INFO] asm:asm-commons:jar:3.2:compile
[INFO] asm:asm-tree:jar:3.2:compile
[INFO] asm:asm-util:jar:3.2:compile
[INFO] org.apache.ant:ant:jar:1.8.1:compile
[INFO] org.apache.maven:maven-plugin-api:jar:2.0.6:compile
[INFO] org.beanshell:bsh:jar:2.0b4:compile
[INFO] org.codehaus.groovy:groovy:jar:1.8.3:compile
[INFO] org.codehaus.plexus:plexus-utils:jar:2.0.5:compile
We should follow the same pattern as the one used by this CQ:
https://dev.eclipse.org/ipzilla/show_bug.cgi?id=5252
Is that correct?
--
Mickael Istria
Eclipse developer at JBoss, by Red Hat <http://www.jboss.org/tools>
My blog <http://mickaelistria.wordpress.com> - My Tweets
<http://twitter.com/mickaelistria>
--
Wayne Beaton
The Eclipse Foundation
Twitter: @waynebeaton
Explore Eclipse Projects <http://www.eclipse.org/projects>
EclipseCon 2013 <http://www.eclipsecon.org/2013>
--
Mickael Istria
Eclipse developer at JBoss, by Red Hat <http://www.jboss.org/tools>
My blog <http://mickaelistria.wordpress.com> - My Tweets
<http://twitter.com/mickaelistria>
_______________________________________________
tycho-dev mailing list
tycho-dev@xxxxxxxxxxx
https://dev.eclipse.org/mailman/listinfo/tycho-dev
--
Mickael Istria
Eclipse developer at JBoss, by Red Hat <http://www.jboss.org/tools>
My blog <http://mickaelistria.wordpress.com> - My Tweets
<http://twitter.com/mickaelistria>
_______________________________________________
tycho-dev mailing list
tycho-dev@xxxxxxxxxxx
https://dev.eclipse.org/mailman/listinfo/tycho-dev
