[
Date Prev][
Date Next][
Thread Prev][
Thread Next][
Date Index][
Thread Index]
[
List Home]
|
Re: [tycho-dev] gerrit @ eclipse
|
go back to the patchset overview and hit "Review", then "Publish Comments"
Jan
-----Original Message-----
From: tycho-dev-bounces@xxxxxxxxxxx [mailto:tycho-dev-bounces@xxxxxxxxxxx] On Behalf Of Igor Fedorenko
Sent: Freitag, 13. April 2012 13:40
To: tycho-dev@xxxxxxxxxxx
Subject: Re: [tycho-dev] gerrit @ eclipse
I must be blind, but I still don't see a way to publish comments, only
edit and discard them.
This is probable what I _should_ be doing with the most of the comments
I make... maybe Gerrit just knows better. :-)
--
Regards,
Igor
On 12-04-13 7:31 AM, Sievers, Jan wrote:
> just double-click on the line you want to comment
>
> Jan
>
> -----Original Message-----
> From: tycho-dev-bounces@xxxxxxxxxxx [mailto:tycho-dev-bounces@xxxxxxxxxxx] On Behalf Of Igor Fedorenko
> Sent: Freitag, 13. April 2012 13:18
> To: tycho-dev@xxxxxxxxxxx
> Subject: Re: [tycho-dev] gerrit @ eclipse
>
> Dumb question. How do I add comments to changes under review? I can't
> find a way to do this in Gerrit web ui. Can somebody post a screenshot
> of what I should be looking for?
>
> --
> Regards,
> Igor
>
> On 12-03-09 4:34 AM, Oberlies, Tobias wrote:
>> Configuration chages requrested: https://bugs.eclipse.org/bugs/show_bug.cgi?id=373748
>>
>>> -----Original Message-----
>>> From: tycho-dev-bounces@xxxxxxxxxxx [mailto:tycho-dev-bounces@xxxxxxxxxxx]
>>> On Behalf Of Mykola Nikishov
>>> Sent: Donnerstag, 8. März 2012 20:53
>>> To: tycho-dev@xxxxxxxxxxx
>>> Subject: Re: [tycho-dev] gerrit @ eclipse
>>>
>>> On 03/08/2012 02:47 PM, Oberlies, Tobias wrote:
>>>
>>> Do you really mean 'to provide a Change-Id _manually_'? Just install the
>>> commit-msg hook [1] and you're done.
>>
>> I know that there are ways... Unfortunately, egit is not an option on Windows because we only want LF in the Tycho git repositories and egit still doesn't support core.autocrlf [2]
>>
>> Regards
>> Tobias
>>
>> [2] https://bugs.eclipse.org/bugs/show_bug.cgi?id=301775
>>
>>> [1]
>>> http://wiki.eclipse.org/Gerrit#Install_the_commit-
>>> msg_hook_in_your_repository
>>>
>>> --
>>> Mykola
>>>
>>> http://ua.linkedin.com/in/manandbytes
>>> https://github.com/manandbytes/
>>> _______________________________________________
>>> tycho-dev mailing list
>>> tycho-dev@xxxxxxxxxxx
>>> https://dev.eclipse.org/mailman/listinfo/tycho-dev
>> _______________________________________________
>> tycho-dev mailing list
>> tycho-dev@xxxxxxxxxxx
>> https://dev.eclipse.org/mailman/listinfo/tycho-dev
> _______________________________________________
> tycho-dev mailing list
> tycho-dev@xxxxxxxxxxx
> https://dev.eclipse.org/mailman/listinfo/tycho-dev
> _______________________________________________
> tycho-dev mailing list
> tycho-dev@xxxxxxxxxxx
> https://dev.eclipse.org/mailman/listinfo/tycho-dev
