[
Date Prev][
Date Next][
Thread Prev][
Thread Next][
Date Index][
Thread Index]
[
List Home]
|
Re: [tycho-dev] Gerrit by-pass still possible
|
So we leave the option open to push directly to master, by-passing code review? I actually think that this is a good idea, so that we can directly push trivial changes or simple refactorings. IMHO we only need code review for "interesting", i.e. functional or non-trivial changes.
Regards
Tobias
> -----Original Message-----
> From: tycho-dev-bounces@xxxxxxxxxxx [mailto:tycho-dev-bounces@xxxxxxxxxxx]
> On Behalf Of Sievers, Jan
> Sent: Dienstag, 3. April 2012 09:14
> To: Tycho developers list
> Subject: Re: [tycho-dev] Gerrit by-pass still possible
>
> see https://bugs.eclipse.org/bugs/show_bug.cgi?id=371620
>
> From: tycho-dev-bounces@xxxxxxxxxxx [mailto:tycho-dev-bounces@xxxxxxxxxxx]
> On Behalf Of Oberlies, Tobias
> Sent: Montag, 2. April 2012 18:12
> To: Tycho developers list
> Subject: [tycho-dev] Gerrit by-pass still possible
>
> Hi Tycho committers,
>
> I've just tried to push directly to our Git repository, and contrary to
> what I expected, the push succeeded. Since we want to use Gerrit, I'll
> open a bug report to have these direct pushes prevented in future. (I'll
> make sure to update our developers' guide first though.)
>
> *If* we should decide to allow pushes without code review, I'd propose to
> only allow this via the Gerrit server (this is something that may be
> configured per project; example). IMHO, this is a lot less confusing than
> the current complete by-pass of Gerrit and the Gerrit rights management.
>
> Regards
> Tobias
>
>
> _______________________________________________
> tycho-dev mailing list
> tycho-dev@xxxxxxxxxxx
> https://dev.eclipse.org/mailman/listinfo/tycho-dev
