Skip to main content

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index] [List Home]
Re: [tycho-dev] first org.eclipse.tycho commit

here are my leftovers for the file headers/copyright notices:

- Following java files have a non-EPL license header (these are all apache license):

maven-osgi-compiler-plugin/src/main/java/org/eclipse/tycho/osgicompiler/AbstractOsgiCompilerMojo.java
maven-osgi-compiler-plugin/src/main/java/org/eclipse/tycho/osgicompiler/OsgiCompilerMojo.java
maven-osgi-compiler-plugin/src/main/java/org/eclipse/tycho/osgicompiler/OsgiTestCompilerMojo.java
maven-osgi-compiler-plugin/src/main/java/org/eclipse/tycho/osgicompiler/copied/AbstractCompilerMojo.java
maven-osgi-compiler-plugin/src/main/java/org/eclipse/tycho/osgicompiler/copied/CompilationFailureException.java
maven-osgi-source-plugin/src/main/java/org/eclipse/tycho/source/AbstractSourceJarMojo.java
tycho-surefire/org.eclipse.tycho.surefire.junit/src/org/eclipse/tycho/surefire/junit/JUnitDirectoryTestSuite.java
tycho-surefire/org.eclipse.tycho.surefire.junit/src/org/eclipse/tycho/surefire/junit/JUnitTestSet.java
tycho-testing-harness/src/main/java/org/eclipse/tycho/testing/EmptyLifecycleExecutor.java

We will probably have to add a "3rd party about file template" [1] to these projects.
I propose we do this together with the 3rd party CQs for the dependencies.

- Following projects have checked-in binaries under apache license and will also need a 3rd-party about notice:

tycho-surefire/org.eclipse.tycho.surefire.junit
tycho-surefire/org.eclipse.tycho.surefire.junit4

BTW, I wonder why the jars are checked in to SCM. 
Shouldn't we rather include the jars via copy-dependencies for GAVs

org.apache.maven.surefire:surefire-junit:2.4.3
org.apache.maven.surefire:surefire-junit4:2.4.3

? Then this case falls back to the normal 3rd party dependencies process.

Regards,
Jan

[1] http://www.eclipse.org/legal/epl/about.php 

-----Original Message-----
From: tycho-dev-bounces@xxxxxxxxxxx [mailto:tycho-dev-bounces@xxxxxxxxxxx] On Behalf Of Sievers, Jan
Sent: Dienstag, 12. April 2011 14:39
To: Tycho developers list
Subject: Re: [tycho-dev] first org.eclipse.tycho commit

file headers are added now to *.java, plugin.xml, plugin.properties, build.properties, pom.xml.

Regards,
Jan

-----Original Message-----
From: tycho-dev-bounces@xxxxxxxxxxx [mailto:tycho-dev-bounces@xxxxxxxxxxx] On Behalf Of Sievers, Jan
Sent: Montag, 11. April 2011 15:29
To: Tycho developers list
Subject: Re: [tycho-dev] first org.eclipse.tycho commit

the package rename is done [1].
All ITs are passing.

@Igor can you reactivate tycho CI build jobs [2] ?

Up next is adding the file headers.

Regards,
Jan

[1] https://github.com/sonatype/sonatype-tycho/commit/ccbe5c2f2007da9ec0a0f9e25df8a36f740c2ff9
[2] https://grid.sonatype.org/ci/view/Tycho/ 


-----Original Message-----
From: tycho-dev-bounces@xxxxxxxxxxx [mailto:tycho-dev-bounces@xxxxxxxxxxx] On Behalf Of Igor Fedorenko
Sent: Donnerstag, 7. April 2011 13:32
To: tycho-dev@xxxxxxxxxxx
Subject: Re: [tycho-dev] first org.eclipse.tycho commit

Correction. All integration tests pass too. I do not plan to make any
changes to Tycho until you are done with package name changes.

--
Regards,
Igor

On 11-04-07 01:39 AM, Igor Fedorenko wrote:
> Jan, Tobias,
>
> As discussed, I've updated all tycho projects to use org.eclipse.tycho
> namespace in their groupId and artifact id and pushed my changes to
> github [1].
>
> Everything compiles and all unit tests pass, but there are still three
> or four failing integration tests. I'll look at them tomorrow. I also
> need to deal with few prebuilt dependencies using old org.sonatype.tycho
> groupId (org.eclipse.jdt.core, org.eclipse.osgi and few of others used
> by the tests).
>
> At this point I do not expect any major changes from "my" work, so you
> can start updating package names.
>
> [1]
> https://github.com/sonatype/sonatype-tycho/commit/147dfdd685cab94f1212c6f1cd0ffaf4c72d8c47
>
>
> --
> Regards,
> Igor
_______________________________________________
tycho-dev mailing list
tycho-dev@xxxxxxxxxxx
https://dev.eclipse.org/mailman/listinfo/tycho-dev
_______________________________________________
tycho-dev mailing list
tycho-dev@xxxxxxxxxxx
https://dev.eclipse.org/mailman/listinfo/tycho-dev
_______________________________________________
tycho-dev mailing list
tycho-dev@xxxxxxxxxxx
https://dev.eclipse.org/mailman/listinfo/tycho-dev


Back to the top