Re: [tracecompass-dev] Trace filters not working in Eclipse Oxygen relea

[Matthew Khouzam <matthew.khouzam@xxxxxxxxxxxx>]

Could you try using a breakpoint on "TmfFilterNode#matches", that is
where the meat of the filters resides.


On 17-10-26 11:55 AM, David Wootton wrote:
>
> Matthew
>
> There's not much I can post. I could post one of my aspects, but I'm
> seeing the problem with the 'Event type' column in the trace editor
> view, where the aspect definition is obtained by calling
> TmfBaseAspects.getEventTypeAspect() as well.
>
> I'm using the trace editor view and the filter view as-is in my
> plugins where I do not extend those classes. The filter view is
> referenced in my plugin using the view identifier
> org.eclipse.linuxtools.tmf.ui.views.filter which did work last year.
>
> My work was mainly in coding the class that loads my trace file into
> the viewer, the state system extensions and extension of the
> CallStackView class, where I don't think I have done anything that
> could interfere with the workings of the trace editor view or the
> filtering mechanism, where the only likely candidate is if I've done
> something to the state system.
>
> If you're not aware of any code changes from Neon to Oxygen, then I
> must have done something to cause this.
>
> If you have suggestions where I might try to look at/debug source
> code, that would be appreciated. Other than filtering, the trace
> editor view seems to be working correctly for me.
>
> Dave
>
> Inactive hide details for Matthew Khouzam ---10/26/2017 09:54:08
> AM---Hi Dave, I really hate to say this, it works for me...Matthew
> Khouzam ---10/26/2017 09:54:08 AM---Hi Dave, I really hate to say
> this, it works for me...
>
> From: Matthew Khouzam <matthew.khouzam@xxxxxxxxxxxx>
> To: <tracecompass-dev@xxxxxxxxxxx>
> Date: 10/26/2017 09:54 AM
> Subject: Re: [tracecompass-dev] Trace filters not working in Eclipse
> Oxygen release
> Sent by: tracecompass-dev-bounces@xxxxxxxxxxx
>
> ------------------------------------------------------------------------
>
>
>
> Hi Dave,
>
> I really hate to say this, it works for me...
>
> Are you using things that you can share online? Maybe we can see your
> aspect?
>
> BR
>
> Matthew
>
>
> On 17-10-26 09:05 AM, David Wootton wrote:
> >
> > Hi
> > My plugins use the trace filter view
> > org.eclipse.tracecompass.tmf.ui.views.filter.FilterView to allow the
> > user to define filters to filter events in the trace editor view. This
> > worked fin in the Neon Eclipse release but is not working any more in
> > the Oxygen release.
> >
> > I can define a filter and save it so that it shows up in the filter
> > list when I right click in the trace editor view. However, when I
> > select that filter, the updated trace editor view always shows me an
> > empty view with no events.
> >
> > I have tried simple filters with only a single Aspect, where I have
> > tried using the Equals, Matches and Contains conditions as well as
> > ignoring case, and none of them show any matching events.
> >
> > The Aspect classes I use simply implement the ITmfEventAspect
> > interface where the resolve method returns a String object containing
> > the value of the requested field, where that value shows up correctly
> > in the trace editor view.
> >
> > Has something changed between the Neon and Oxygen SR1 releases that
> > affects how trace filters are supposed to work, and which I may not
> > have realized?
> >
> > Dave
> >
> >
> > _______________________________________________
> > tracecompass-dev mailing list
> > tracecompass-dev@xxxxxxxxxxx
> > To change your delivery options, retrieve your password, or
> unsubscribe from this list, visit
> >
> https://urldefense.proofpoint.com/v2/url?u=https-3A__dev.eclipse.org_mailman_listinfo_tracecompass-2Ddev&d=DwICAg&c=jf_iaSHvJObTbx-siA1ZOg&r=yA1Giwd7Ls577uUKQ3fQWICGHopYggQ46OvlB30WK5M&m=W5ll3bCBlBLvS-pFP7OyQVd0AWn8M3jMiOrQZH_wKTw&s=x92EscW_6gkhI80T2WKASs8KuQnYido3l0aGy5TKrdQ&e=
>
> _______________________________________________
> tracecompass-dev mailing list
> tracecompass-dev@xxxxxxxxxxx
> To change your delivery options, retrieve your password, or
> unsubscribe from this list, visit
> https://urldefense.proofpoint.com/v2/url?u=https-3A__dev.eclipse.org_mailman_listinfo_tracecompass-2Ddev&d=DwICAg&c=jf_iaSHvJObTbx-siA1ZOg&r=yA1Giwd7Ls577uUKQ3fQWICGHopYggQ46OvlB30WK5M&m=W5ll3bCBlBLvS-pFP7OyQVd0AWn8M3jMiOrQZH_wKTw&s=x92EscW_6gkhI80T2WKASs8KuQnYido3l0aGy5TKrdQ&e=
>
>
>
>
>
>
> _______________________________________________
> tracecompass-dev mailing list
> tracecompass-dev@xxxxxxxxxxx
> To change your delivery options, retrieve your password, or unsubscribe from this list, visit
> https://dev.eclipse.org/mailman/listinfo/tracecompass-dev