Re: [tools-pmc] TCF Contribution "under the supervision of the PMC"

["Oberhuber, Martin" <Martin.Oberhuber@xxxxxxxxxxxxx>]

Hi all,

Thanks for the +1 , since there was no veto after today's meeting we will proceed with the checkin.

Regarding the size, the contribution has 2 new plugins so just the scaffolding takes approx. 1000 LOC (especially .settings/org.eclipse.jdt.core.prefs). Beyond that, the contribution provides a full EFS/IFileStore implementation including fetchInfo()/putInfo(), remote processes implementation, event/notification handling and bridges synchronous vs. asynchronous API. IMO the contribution is very well written, split into appropriate classes with documentation - no spaghetti code; thus the size is very reasonable and I'd assume any o.e.remote implementation for the file and process services would be similar in size.

Thanks,
Martin
--
Martin Oberhuber, SMTS / Product Owner - Development Tools, Wind River
direct +43.662.457915.85  fax +43.662.457915.6

-----Original Message-----
From: tools-pmc-bounces@xxxxxxxxxxx [mailto:tools-pmc-bounces@xxxxxxxxxxx] On Behalf Of Doug Schaefer
Sent: Tuesday, January 13, 2015 3:48 PM
To: Tools PMC mailing list
Subject: Re: [tools-pmc] TCF Contribution "under the supervision of the PMC"

+1. Supervision is pretty ill defined but if you are representing the 
+code
and can vouch for it¹s IP cleanliness, I¹m OK with it.

Little confused why it would take that much code to adapt o.e.remote to TCF, but we can reserve that discussion for the project mailing list.

Doug.

On 2015-01-13, 9:01 AM, "Aleksandar Kurtakov" <akurtako@xxxxxxxxxx> wrote:

>----- Original Message -----
>> From: "David M Williams" <david_williams@xxxxxxxxxx>
>> To: "Tools PMC mailing list" <tools-pmc@xxxxxxxxxxx>
>> Sent: Tuesday, January 13, 2015 3:35:29 PM
>> Subject: Re: [tools-pmc] TCF Contribution "under the supervision of 
>>the PMC"
>> 
>> +1
>> 
>> Sounds ok by me. Seems to meet the spirit of the rule.
>
>+1 from me too.
>
>> 
>> Other PMC members, please say if you'd like to meet (on phone) to 
>>discuss  this or other topics ... tomorrow, 1/14 is the "Second 
>>Wednesday" of the  Month, when we'd normally have a meeting, if there 
>>is an agenda.
>> 
>> Please say if anyone wants that meeting for this, or other topics.
>
>I have nothing for this meeting.
>
>Alexander Kurtakov
>Red Hat Eclipse team
>
>> 
>> Thanks,
>> 
>> 
>> 
>> 
>> From: "Oberhuber, Martin" <Martin.Oberhuber@xxxxxxxxxxxxx>
>> To: "tools-pmc@xxxxxxxxxxx" <tools-pmc@xxxxxxxxxxx>,
>> Cc: "Schorn, Markus" <Markus.Schorn@xxxxxxxxxxxxx>, "Stieber, Uwe"
>> <Uwe.Stieber@xxxxxxxxxxxxx>, "janet.campbell@xxxxxxxxxxx"
>> <janet.campbell@xxxxxxxxxxx>
>> Date: 01/13/2015 04:27 AM
>> Subject: [tools-pmc] TCF Contribution "under the supervision of the PMC"
>> Sent by: tools-pmc-bounces@xxxxxxxxxxx
>> 
>> 
>> 
>> 
>> Dear Tools PMC,
>> 
>> For the TCF Project, we would like to commit following contribution:
>> 
>> https://git.eclipse.org/r/#/c/38323/
>> 
>> This contribution is 4283 lines of code. It was written 100% by 
>>employees of  the same company as the committer (Wind River), and a 
>>Member Committer  Agreement is in place. Also, the contributor is 
>>committer on CDT (but not  yet on TCF).
>> 
>> According to Legal Process Poster:
>> https://www.eclipse.org/legal/EclipseLegalProcessPoster.pdf
>> page 1 / figure2 we should be able to commit this without extra due 
>>diligence  effort on the IP team, if the PMC agrees this is OK (see 
>>also page 3).
>> 
>> I can confirm that the contribution is needed for the project, and we 
>>have  observed due diligence guidelines as every committer would do.
>> 
>> Do you agree we can commit this without putting extra burden on the 
>>IP team ?
>> 
>> Thanks,
>> Martin
>> --
>> Martin Oberhuber , SMTS / Product Owner ­ Development Tools, Wind 
>>River  direct +43.662.457915.85 fax +43.662.457915.6  
>>_______________________________________________
>> tools-pmc mailing list
>> tools-pmc@xxxxxxxxxxx
>> To change your delivery options, retrieve your password, or 
>>unsubscribe from  this list, visit  
>>https://dev.eclipse.org/mailman/listinfo/tools-pmc
>> 
>> _______________________________________________
>> tools-pmc mailing list
>> tools-pmc@xxxxxxxxxxx
>> To change your delivery options, retrieve your password, or 
>>unsubscribe from  this list, visit  
>>https://dev.eclipse.org/mailman/listinfo/tools-pmc
>_______________________________________________
>tools-pmc mailing list
>tools-pmc@xxxxxxxxxxx
>To change your delivery options, retrieve your password, or unsubscribe 
>from this list, visit 
>https://dev.eclipse.org/mailman/listinfo/tools-pmc

_______________________________________________
tools-pmc mailing list
tools-pmc@xxxxxxxxxxx
To change your delivery options, retrieve your password, or unsubscribe from this list, visit https://dev.eclipse.org/mailman/listinfo/tools-pmc