Skip to main content

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index] [List Home]
Re: [tm-dev] Moving the "TCF Terminals" code to the TM Project

Thanks Wayne !

 

Doug, you seem to have experience splitting component(s) into their own git repo. Can you give any advice here ?

 

Maybe splitting out a new org.eclipse.tm.terminal.git would be the easiest, making sure that it has its own self-contained build ?

I think you’ve done something similar recently with the LaunchBar, and planning again with cdt.native.

Any advice would be appreciated.

 

Thanks,

Martin

--

Martin Oberhuber, SMTS / Product Owner – Development Tools, Wind River

direct +43.662.457915.85  fax +43.662.457915.6

 

From: Wayne Beaton [mailto:wayne@xxxxxxxxxxx]
Sent: Monday, March 16, 2015 6:22 PM
To: Oberhuber, Martin; TM project developer discussions; Greg Watson <g.watson@xxxxxxxxxxxx> (g.watson@xxxxxxxxxxxx); Doug Schaefer (cdtdoug@xxxxxxxxx)
Subject: Re: Moving the "TCF Terminals" code to the TM Project

 

I have a couple of other reviews that I need to squeeze into March. I'd like to move this forward to March 25. I don't think that should affect any of the plans. I don't think that this will give you time to get into M6, but maybe...

You can start the process of splitting the repository any time. Ask the webmaster team for assistance. I believe that they have experience splitting a Git repository (while preserving history).

How you split it is your call.

Wayne

On 16/03/15 12:54 PM, Oberhuber, Martin wrote:

Thanks Wayne,

 

I have just submitted the TCF IP Log:

https://www.eclipse.org/projects/ip_log.php?projectid=tools.cdt.tcf

Note that only a subset of org.eclipse.tcf.git is a candidate for the move, but *not* org.eclipse.tcf.agent.git .

 

Next question would be, how can we split the RSE Git Repo from the TM Git Repo.

This could be done inside the TM project in preparation of the move (and would be a good thing anyways since RSE now has a very different community than TM Core) ?

Would webmaster do that ?

 

Looking at the current tm repo:
http://git.eclipse.org/c/tm/org.eclipse.tm.git/tree/?h=master

Here is my immediate thinking (to be validated by others)

-          “terminal” should go into a NEW, smaller org.eclipse.tm.git

-          “rse” and “wince” should go into org.eclipse.rse.git

-          “admin/” and “releng/” should be duplicated in both org.eclpse.tm.git and org.eclipse.rse.git

 

Thanks,

Martin

--

Martin Oberhuber, SMTS / Product Owner – Development Tools, Wind River

direct +43.662.457915.85  fax +43.662.457915.6

 

From: Wayne Beaton [mailto:wayne@xxxxxxxxxxx]
Sent: Monday, March 16, 2015 2:27 PM
To: Oberhuber, Martin; TM project developer discussions; Greg Watson <g.watson@xxxxxxxxxxxx> (g.watson@xxxxxxxxxxxx); Doug Schaefer (cdtdoug@xxxxxxxxx)
Subject: Re: Moving the "TCF Terminals" code to the TM Project

 

My apologies for the delay (pesky EclipseCon).

I've created the review record and have scheduled the review to conclude on April 1.

https://projects.eclipse.org/projects/tools.cdt.tcf/reviews/move-tcf-terminals-code-tm-project

Since code is moving, we'll need an approved IP Log from TCF. Can somebody please submit that for review?

Thanks,

Wayne


On 09/03/15 05:24 AM, Oberhuber, Martin wrote:

Hi Wayne, all –

 

So my understanding is that we have to wait for the restructuring review to be completed, before we can actually move the code.

 

Wayne:

With the paragraph below, do you have everything to initiate the restructuring review ?
When do you expect it to be completed ?

 

Thanks,

Martin

--

Martin Oberhuber, SMTS / Product Owner – Development Tools, Wind River

direct +43.662.457915.85  fax +43.662.457915.6

 

From: tm-dev-bounces@xxxxxxxxxxx [mailto:tm-dev-bounces@xxxxxxxxxxx] On Behalf Of Oberhuber, Martin
Sent: Friday, March 06, 2015 10:04 PM
To: Wayne Beaton; Greg Watson <g.watson@xxxxxxxxxxxx> (g.watson@xxxxxxxxxxxx); Doug Schaefer (cdtdoug@xxxxxxxxx)
Cc: TM project developer discussions
Subject: Re: [tm-dev] Moving the "TCF Terminals" code to the TM Project

 

Thanks Wayne,

 

So here is a draft of the description paragraph:

 

----------------------

As part of the TCF Target Explorer, an enhanced Terminal View has been developed over the past couple years.

With the addition of Local Terminal support for Windows, this view has gained considerable Community interest,

and the difference (fork) between the original TM Terminal View and the TCF one has become a problem.

 

The proposed restructuring intends to bring back the TCF Terminals View into the TM project and merge it with

the original TM code such that a single enhanced, unified Terminal View can be leveraged by all consumers.

Moreover, unifying the code will make it easier to consume for contributors.  The TCF Code to move resides under
   https://git.eclipse.org/c/tcf/org.eclipse.tcf.git/tree/terminals

and has no dependencies other than TM and Platform. The relevant IP Log resides at

   https://www.eclipse.org/projects/ip_log.php?projectid=tools.cdt.tcf
The TM and TCF Project Leads and committers have confirmed that they both want this restructuring.

-------------------------

 

HTH, please let me know if you need anything else !

 

 

Thanks,

Martin

--

Martin Oberhuber, SMTS / Product Owner – Development Tools, Wind River

direct +43.662.457915.85  fax +43.662.457915.6

 

From: Wayne Beaton [mailto:wayne@xxxxxxxxxxx]
Sent: Friday, March 06, 2015 9:46 PM
To: Oberhuber, Martin; Greg Watson <g.watson@xxxxxxxxxxxx> (g.watson@xxxxxxxxxxxx); Doug Schaefer (cdtdoug@xxxxxxxxx)
Cc: TM project developer discussions
Subject: Re: Moving the "TCF Terminals" code to the TM Project

 

If code is being moved from one project to another, we'll need to do a restructuring review. For this, we'll need an IP Log review and a paragraph describing what you want to do (I'll create the review record based on this paragraph).

When we move the code, we'll keep the commits intact, and credit for the contributions will move to the destination project's IP Log. If the commits are copied, the credit will exist in both IP Logs. If we squash the history (not recommended), we'll lose any record of the contributors (unless we include them as "Also-by" entries in the squashed commit).

I'm in favour of using a separate Git repository if that makes things easier for all involved.

I hope that this makes sense.

Wayne

On 06/03/15 03:35 PM, Oberhuber, Martin wrote:

Hi Greg, Doug, Wayne –

 

On our side, we are ready for bringing the refactored TCF Terminals View code from TCF into TM, as discussed previously.

 

Before we “Just commit the code” as you had proposed, I would like to check again with Wayne whether a Restructuring Review would be adviseable, for two reasons:

 

1.      Checking the TCF IP Log, there have been contributions at least from Max Weninger and Markus Schorn to the TCF Terminals. Both work for Wind River (Member Agreement) but are not committers: Do such IP Log Entries need to get moved to the new project ? How ? Would the GIT history do that automatically ?
https://www.eclipse.org/projects/ip_log.php?projectid=tools.cdt.tcf



2.      We need to also move the Bugzilla Backlog for Terminals, so looks like some help from Webmaster will be needed.

 

I would appreciate if the three of you might get a chance hooking up on this subject at EclipseCon and coming up with advice.

That reminds me, regarding the next steps for the proposed “TM 4.0” GIT repository / component:

 

-          Bringing o.e.remote to TM had been discussed. Is this going to happen ? When ?

-          Creating a separate git repo to hold “core components” independent of RSE in TM had been discussed. Is this going to happen ? When ?

 

Having a small, fresh git repo as target for our restructured code would probably make some things simpler.

Comments ? Thoughts ?

 

 

Thanks,

Martin

--

Martin Oberhuber, SMTS / Product Owner – Development Tools, Wind River

direct +43.662.457915.85  fax +43.662.457915.6

 

From: tm-dev-bounces@xxxxxxxxxxx [mailto:tm-dev-bounces@xxxxxxxxxxx] On Behalf Of Doug Schaefer
Sent: Tuesday, February 24, 2015 5:13 PM
To: TM project developer discussions
Subject: Re: [tm-dev] "Terminals" view dependency reduction
Importance: High

 

+1. It’s more an issue when you want to move committers from one project to another. Since you’re committers on both, just fire it over.

 

Having just cleaned up my internal serial port/terminal implementation to get back to the old Terminal View, I got an appreciation of how simple the old view is to extend and how the TCF Terminal integration was more than doubled the size of the code. If we’re going to go with that as our one terminal implementation, I’d like to see how we can simplify that.

 

I also want to see a tighter integration with o.e.remote. All the terminal types can be implemented using remote services with the bonus that they also support other UI elements. With my user hat on, I’m not sure why creating a Terminal and opening a File Browser over the same wire would require different frameworks. I just want to click on my Connection in the Connections view and Open Terminal or Open File Browser and the right things happen. (And, yes, I’ll be adding a file browser with full drag and drop to the o.e.remote UI probably in the Mars.1 timeframe).

 

Doug.

 

From: Greg Watson <g.watson@xxxxxxxxxxxx>
Reply-To: TM project developer discussions <tm-dev@xxxxxxxxxxx>
Date: Tuesday, February 24, 2015 at 10:46 AM
To: TM project developer discussions <tm-dev@xxxxxxxxxxx>
Subject: Re: [tm-dev] "Terminals" view dependency reduction

 

Is a move review even necessary? I think this is only for when whole projects move. In this case, I think you could just create a Gerrit patch and submit it to the TM repo.

 

Greg

 

On Feb 20, 2015, at 1:20 PM, Oberhuber, Martin <Martin.Oberhuber@xxxxxxxxxxxxx> wrote:

 

Hi all,

 

Remaining issues have been fixed, and the refactored terminals view is now available from our Marketplace entry [1] as well as directly from our p2 repository:

 

In order to look at the source, you can simply File > Import > Team > Project set from this URL:

to get all the necessary repos in one step (TM, o.e.remote, TCF) with projects categorized into Working Sets.

 

We now need to decide on the next steps to ensure that we can align on this as the common Terminals view for Eclipse.

If a Move Review / Restructuring Review is desired to move over the sources into TM, we’d appreciate guidance from Greg and Doug.

The alternative would be just updating the EPP packages to use the new terminals view instead of the now deprecated legacy one.

 

Comments or thoughts are most welcome at this point !

 

 

Thanks,

Martin

--

Martin Oberhuber, SMTS / Product Owner – Development Tools, Wind River

direct +43.662.457915.85  fax +43.662.457915.6

 

From: tm-dev-bounces@xxxxxxxxxxx [mailto:tm-dev-bounces@xxxxxxxxxxx] On Behalf Of Stieber, Uwe
Sent: Monday, February 09, 2015 2:14 PM
To: TM project developer discussions
Subject: [tm-dev] "Terminals" view dependency reduction

 

Hi guys,

 

Please note that the proposed dependency reduction for the “Terminals” view implementation has been completed. If you install the terminals feature from our nightly build repository [1], you want see any other o.e.tcf feature/plug-in, nor will you get GSON. The only external dependency the “Terminals” view have is to org.eclipse.cdt.core.native to support the local terminal functionality. The marketplace contribution will be updated soon.

 

Best regards, Uwe J

 

_______________________________________________
tm-dev mailing list
tm-dev@xxxxxxxxxxx
To change your delivery options, retrieve your password, or unsubscribe from this list, visit
https://dev.eclipse.org/mailman/listinfo/tm-dev

 

 

--
Wayne Beaton
@waynebeaton
The Eclipse Foundation
EclipseCon 2015

 

--
Wayne Beaton
@waynebeaton
The Eclipse Foundation
EclipseCon 2015

 

--
Wayne Beaton on behalf of the Eclipse Management Organization
@waynebeaton
The Eclipse Foundation
EclipseCon 2015

--
Wayne Beaton
@waynebeaton
The Eclipse Foundation
EclipseCon 2015


Back to the top