Skip to main content

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index] [List Home]
Re: [technology-pmc] Adding JCStress dependency for concurrent collections testing in Eclipse Collections

I believe that this can reasonably be considered a "Build and Test" works-with. 

The content in question is licensed GPLv2 with classpath exception, so I believe that this is not a violation of the license terms.

So, per the Policy on the Use of GPL+Classpath Exception by Eclipse Projects, "Use of a GPL+CE-licensed library as a works-with dependency will require approval by the EMO", I believe that we're good-to-go.

Please file a "Build and Test Works With" CQ per the guidance on the wiki

Wayne


On Thu, Apr 5, 2018 at 1:19 PM, Nanivadekar, Nikhil <Nikhil.Nanivadekar@xxxxxx> wrote:

Yes the project test code uses annotations and API. The test code is in the Eclipse Collections GitHub repository maintained by the project team.

 

Thanks,

Nikhil.

 

 

The Goldman Sachs Group, Inc. All rights reserved.

See http://www.gs.com/disclaimer/global_email for important risk disclosures, conflicts of interest and other terms and conditions relating to this e-mail and your reliance on information contained in it.  This message may contain confidential or privileged information.  If you are not the intended recipient, please advise us immediately and delete this message.  See http://www.gs.com/disclaimer/email for further information on confidentiality and the risks of non-secure electronic communication.  If you cannot access these links, please notify us by reply message and we will send the contents to you.

 

From: technology-pmc-bounces@eclipse.org [mailto:technology-pmc-bounces@xxxxxxxxxxx] On Behalf Of Wayne Beaton
Sent: Thursday, April 05, 2018 11:17 AM


To: Technology PMC <technology-pmc@xxxxxxxxxxx>
Subject: Re: [technology-pmc] Adding JCStress dependency for concurrent collections testing in Eclipse Collections

 

We are using the API only during testing. 

 

Does any of the project test code (i.e. code maintained by the project team in a project source code repository) need to implement an API, use an annotation, or anything that might be considered linking?

 

Wayne

 

On Thu, Apr 5, 2018 at 1:13 PM, Nanivadekar, Nikhil <Nikhil.Nanivadekar@xxxxxx> wrote:

Hi Wayne,

 

The dependency is only for testing and is added in a separate module in the project. It will not touch any modules which are pushed to maven central. We are using the API only during testing. Neither the production code nor the released artifacts depend on the API of jcstress.

Regarding gluing it to project code library, the dependency will be downloaded as a part of a maven build (similar to any other maven download). Since this is a stress test we do not plan to run it with every PR but it will be executed using Travis cron jobs.

Happy to create a new CQ per the documentation.

 

Thanks,

Nikhil.

 

 

The Goldman Sachs Group, Inc. All rights reserved.

See http://www.gs.com/disclaimer/global_email for important risk disclosures, conflicts of interest and other terms and conditions relating to this e-mail and your reliance on information contained in it.  This message may contain confidential or privileged information.  If you are not the intended recipient, please advise us immediately and delete this message.  See http://www.gs.com/disclaimer/email for further information on confidentiality and the risks of non-secure electronic communication.  If you cannot access these links, please notify us by reply message and we will send the contents to you.

 

From: technology-pmc-bounces@eclipse.org [mailto:technology-pmc-bounces@xxxxxxxxxxx] On Behalf Of Wayne Beaton
Sent: Thursday, April 05, 2018 11:04 AM
To: Technology PMC <technology-pmc@xxxxxxxxxxx>
Subject: Re: [technology-pmc] Adding JCStress dependency for concurrent collections testing in Eclipse Collections

 

I'm not subscribed to the Eclipse Collections dev list, so you'll have to summarize this discussion there.

 

Combining with the GPL can be a bit problematic from a licensing POV. How do you glue project code to the library? Are there APIs that you need to use? How are those APIs licensed?

 

The wiki page on Test and Build Dependencies rationizes that what you're describing is "works with" and tells you what you need to do.

 

Wayne

 

On Thu, Apr 5, 2018 at 12:51 PM, Nanivadekar, Nikhil <Nikhil.Nanivadekar@xxxxxx> wrote:

Hi PMC

We have a Pull Request for Eclipse Collections wherein we want to add jcstress-based tests for concurrent collections. However, jcstress is GPL licensed. From the Eclipse License FAQ, EPL and GPL are not compatible. Since JCStress will not be a direct dependency but only for build. So, this falls under the “Workswith” Dependencies.

Can you please approve addition of the dependency according to the Eclipse Policy and Procedure for 3rd Party Dependencies guidelines?

PR link: https://github.com/eclipse/eclipse-collections/pull/430

JCStress license link: http://hg.openjdk.java.net/code-tools/jcstress/file/64f2cf32fa0a/LICENSE  

License Wiki link which I referred to: http://www.eclipse.org/legal/eplfaq.php#GPLCOMPATIBLE

Eclipse Policy and Procedure for 3rd Party Dependencies guidelines link: https://www.eclipse.org/org/documents/Eclipse_Policy_and_Procedure_for_3rd_Party_Dependencies_Final.pdf

 

Thanks,

Nikhil.

 

The Goldman Sachs Group, Inc. All rights reserved.

See http://www.gs.com/disclaimer/global_email for important risk disclosures, conflicts of interest and other terms and conditions relating to this e-mail and your reliance on information contained in it.  This message may contain confidential or privileged information.  If you are not the intended recipient, please advise us immediately and delete this message.  See http://www.gs.com/disclaimer/email for further information on confidentiality and the risks of non-secure electronic communication.  If you cannot access these links, please notify us by reply message and we will send the contents to you.

 


_______________________________________________
technology-pmc mailing list
technology-pmc@xxxxxxxxxxx
To change your delivery options, retrieve your password, or unsubscribe from this list, visit
https://dev.eclipse.org/mailman/listinfo/technology-pmc



 

--

Wayne Beaton

Director of Open Source Projects

The Eclipse Foundation


_______________________________________________
technology-pmc mailing list
technology-pmc@xxxxxxxxxxx
To change your delivery options, retrieve your password, or unsubscribe from this list, visit
https://dev.eclipse.org/mailman/listinfo/technology-pmc



 

--

Wayne Beaton

Director of Open Source Projects

The Eclipse Foundation


_______________________________________________
technology-pmc mailing list
technology-pmc@xxxxxxxxxxx
To change your delivery options, retrieve your password, or unsubscribe from this list, visit
https://dev.eclipse.org/mailman/listinfo/technology-pmc



--
Wayne Beaton
Director of Open Source Projects
The Eclipse Foundation

Back to the top