Skip to main content

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index] [List Home]
Re: [technology-pmc] eclipse scout and jshint

Let me rephrase this to make sure I understand… Validation errors in boot.ext.js are visible to developers using Scout. If the developers have jshint installed, it may flag validation problems that you don’t believe should be flagged. To avoid those problems from showing up, you add this comment into code. In effect you are integrating with jshint. I think it is appropriate to require a workswith dependency in this case.

 

Thanks,

 

- Konstantin

 


From: Matthias Zimmermann
Sent: Wednesday, October 7, 2015 12:04 AM
To: Konstantin Komissarchik;technology-pmc@xxxxxxxxxxx
Cc: Sharon Corbett
Subject: RE: [technology-pmc] eclipse scout and jshint

 

 

if anybody should have the jshint eclipse plugin installed in the eclipse ide, the plugin will show errors such as the one explained on stackoverflow [1].

 

in the case of the scout html ui component that will be included with the neon release. we do not want to see these errors in the jshint eclipse plugin for the current (working) code.

 

putting the comment /* jshint -W079 */ anywhere into the scout file boot.ext.js will suppress the reporting for these type of errors in case the jshint plugin is installed in the ide. if no jshint plugin is installed in the eclipse ide, the comment does not do anything (of course).

 

thanks for asking

matthias

 

[1] http://stackoverflow.com/questions/24510773/jshint-error-redefinition-of

 

 

From: Konstantin Komissarchik [mailto:konstantin.komissarchik@xxxxxxxxxx]
Sent: Dienstag, 6. Oktober 2015 18:46
To: Matthias Zimmermann; technology-pmc@xxxxxxxxxxx
Cc: Sharon Corbett
Subject: RE: [technology-pmc] eclipse scout and jshint

 

Could you elaborate on why this comment is present in scout source? Are there any code references from scout to jshint?

 

- Konstantin

 

 


From: Matthias Zimmermann
Sent: Tuesday, October 6, 2015 9:22 AM
To: technology-pmc@xxxxxxxxxxx
Cc: Sharon Corbett
Subject: [technology-pmc] eclipse scout and jshint

 

 

hi pmc

 

during the ip process for the eclipse scout neon release sharon’s team became aware of a comment “*jshint -W079 */” in our own code (which could be removed if this helps to simplify the process).
 
this raised the question if and how the contribution depends on jshint. to determine if a workswith depencendy is required, sharon asked us to discuss this topic with the pmc.
 
current setup:
-          scout developers that wish to have improved warnings/error support for _javascript_ in their eclipse ide can add the JSHint Eclipse plugin from eclipse source. this plugin is available on the eclipse market place [2].
 
-          we do not think that we would need a cq for this. reason: if this requires a workswith cq we would also need a workswith cq for whatever ide plugin that does not break the scout package
 
therefor we now need your opinion/answer to the following questions
1)       do we need a workswith cq for the jshint plugin [2]?
2)       and if yes, why?
 
thanks for feedback and best regards
matthias

 

[1] https://dev.eclipse.org/ipzilla/show_bug.cgi?id=10064

[2] https://marketplace.eclipse.org/content/jshint-eclipse

 

 

 

 

 


Back to the top