[tcf-dev] org.eclipse.tcf.internal.cdt.ui.preferences ; x-internal:=tru

["Oberhuber, Martin" <Martin.Oberhuber@xxxxxxxxxxxxx>]

Hi all,

 

I noticed that org.eclipse.tcf.cdt.ui/META-INF/MANIFEST.MF exports

   org.eclipse.tcf.internal.cdt.ui.preferences

without

   ;x-internal:=true,

As a result, API Tooling reports that an @since 1.4 is missing on two new Preference constants.

 

I am surprised that a package with .internal. in the name is not exported as ;x-internal:=true –

does anybody depend on that API or is it an oversight that should be fixed ?

 

From my POV I am fine with either adding the ;x-internal:=true or adding the missing @since tags,

But one of the two actions should be taken. I’m personally more in favor of adding the ;x-internal:=true

since by social convention the package was marked as internal before so it would just be made official with 1.4.

 

Any thoughts anyone ?

 

Thanks,

Martin

--

Martin Oberhuber, SMTS / Product Owner – Development Tools, Wind River

direct +43.662.457915.85  fax +43.662.457915.6