Skip to main content

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index] [List Home]
Re: [tcf-dev] Multiple agents on localhost?

Hi Michael,

If you launch different agents on the same host, the agent ID of each agent instance should be different. The agent ID used to be taken into account to distinguish between the agent running on the same host. But looking at LocatorModel#validatePeer(...), this code is gone :-(.

The patch you have provided is fine, but before I can apply it, I need you to create a bugzilla issue (https://bugs.eclipse.org, Product "TCF", Component "Target") for the issue. 

Is there a chance that you can submit the patch for review via Gerrit? See https://projects.eclipse.org/projects/tools.cdt.tcf/developer for details. Reference the bugzilla in you commit message. That would the easiest way to get the patch applied.

Thanks, Best regards, Uwe :)



> -----Original Message-----
> From: tcf-dev-bounces@xxxxxxxxxxx [mailto:tcf-dev-bounces@xxxxxxxxxxx] On
> Behalf Of Michael Jahn
> Sent: Dienstag, 18. November 2014 20:14
> To: tcf-dev@xxxxxxxxxxx
> Subject: [tcf-dev] Multiple agents on localhost?
> 
> Hello,
> 
> I would like to run multiple agents on localhost. When I invoke tcf-agent -i and
> issue peers, I can see all all agents properly set up. Eclipse Target Explorer's
> System Management View does only display a single tcf-agent for localhost. I
> believe, that
> org.eclipse.tcf.te.tcf.locator.nodes.LocatorModel.validatePeer() causes this
> behavior.
> validatePeer() tries to find a local interface for a peer, and remove all other
> interfaces for this peer, if the peer is using a TCP or SSL channel. Because
> validatePeer() does not take the port (a TCP host:port-tuple is sufficient to
> distinguish two peers) of the agent into account, different peers are assumed
> identical.
> 
> A patch, that seems to fix this problem, is attached.
> 
> Kind regards,
> 
> Michael Jahn



Back to the top