| Re: [tcf-dev] Invalid/unacceptable changes in org.eclipse.tcf.core |
|
Hi Tobias,
Compatibility is high priority goal. Code that does not terminate JSON with \0 is not compatible with existing TCF implementations. Your changes would allow such invalid code to go undetected, eventually leading to compatibility problems down the road.
Regards, Eugene
From: Schwarz, Tobias [mailto:tobias.schwarz@xxxxxxxxxxxxx]
Hi eugene,
This change was more for safety reason if just the ending \0 is missing.
If the \0 at the end is missing, JSON throws an IOException. If the format is still invalid, even after adding the \0, JSON will throw an exception.
Feel free to revert the commit if it breaks any spec, otherwise I think it would not lead to wrong data because if there was an error in data transfer, normally more than the \0 is missing and so JSON generates an error. But it would add a little bit of safety if a service does not send the leading \0.
Regards tobias
From: Eugene Tarassov [mailto:eugene.tarassov@xxxxxxxxxx]
I’m going to revert a recent commit in TCF Core that violates TCF protocol specs. Please, let me know if there is a good reason to keep the changes. The commit is:
Revision: f83749b307e0feedb9f1db263a96469de47ef654 Author: Tobias Schwarz <tobias.schwarz@xxxxxxxxxxxxx> Date: 06.11.2013 01:01:31 Message: Target Explorer: add \0 char at the end of result data if missing ---- Modified: plugins/org.eclipse.tcf.core/src/org/eclipse/tcf/core/Command.java
Regards, Eugene
This email and any attachments are intended for the sole use of the named recipient(s) and contain(s) confidential information that may be proprietary, privileged or copyrighted under applicable law. If you are not the intended recipient, do not read, copy, or forward this email message or any attachments. Delete this email message and any attachments immediately. |