Re: [tcf-dev] org.eclipse.tm.terminal.view dependency of org.eclipse.tcf

[Eugene Tarassov <eugene.tarassov@xxxxxxxxxx>]

Hi Martin, Uwe,

I did not know org.eclipse.tm.terminal.view is deprecated. I have not seen any indication of that in the Target Management project plans.

I think it is OK to use reflection for now, but what are Target Management "official" recommendations for adopters of TM Terminal feature?

Regards,
Eugene

-----Original Message-----
From: tcf-dev-bounces@xxxxxxxxxxx [mailto:tcf-dev-bounces@xxxxxxxxxxx] On Behalf Of Oberhuber, Martin
Sent: Wednesday, October 09, 2013 11:39 PM
To: TCF Development
Subject: Re: [tcf-dev] org.eclipse.tm.terminal.view dependency of org.eclipse.tcf.debug.ui

Thanks Uwe for proceeding quickly and unblocking us.

Eugene, can you consider Uwe's concerns and think about a better solution for what you are trying to accomplish ?
If things need more discussion , is there a bugzilla item for tracking the discussion ?

Thanks,
Martin
--
Martin Oberhuber, SMTS / Product Architect - Development Tools, Wind River
direct +43.662.457915.85  fax +43.662.457915.6


-----Original Message-----
From: tcf-dev-bounces@xxxxxxxxxxx [mailto:tcf-dev-bounces@xxxxxxxxxxx] On Behalf Of Stieber, Uwe
Sent: Thursday, October 10, 2013 8:29 AM
To: TCF Development (tcf-dev@xxxxxxxxxxx)
Subject: [tcf-dev] org.eclipse.tm.terminal.view dependency of org.eclipse.tcf.debug.ui
Importance: High

Hi Eugene,

We found that you have added a hard dependency to "org.eclipse.tm.terminal.view" from "org.eclipse.tcf.debug.ui". This dependency is very problematic. First of all, the "org.eclipse.tm.terminal.view" plugin should not be used any longer, this one represents the old, legacy, deprecated terminal view which we are not longer maintaining. The new terminal view to be used, and the only one maintained, is the one coming from "org.eclipse.tcf.te.ui.terminals". Second, this dependency is breaking our product delivery as we cannot add the "org.eclipse.tm.terminal.view" plugin to our packaging. It does even break our build.

It would be very helpful if you could consider switching to the new terminal view provided by the "org.eclipse.tcf.te.ui.terminals" plugin. Besides, the new terminal view is supporting "TCF Terminal" since a long time already. The old terminal view should not be referenced in any new code, it will be removed from the terminal delivery eventuelly.

To solve the issue, I kept the code as you have added it, but made the dependency optional and used reflection to invoke ITerminalView#newTerminal(ITerminalConnector). Means you should not see any difference in functionality as you have added it originally and now, but the hard dependency is gone and our build is unblocked.

Thanks, Best regards, Uwe :)

_______________________________________________
tcf-dev mailing list
tcf-dev@xxxxxxxxxxx
https://dev.eclipse.org/mailman/listinfo/tcf-dev
_______________________________________________
tcf-dev mailing list
tcf-dev@xxxxxxxxxxx
https://dev.eclipse.org/mailman/listinfo/tcf-dev



This email and any attachments are intended for the sole use of the named recipient(s) and contain(s) confidential information that may be proprietary, privileged or copyrighted under applicable law. If you are not the intended recipient, do not read, copy, or forward this email message or any attachments. Delete this email message and any attachments immediately.